From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756141Ab2KWRvJ (ORCPT ); Fri, 23 Nov 2012 12:51:09 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:35448 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755931Ab2KWRvG (ORCPT ); Fri, 23 Nov 2012 12:51:06 -0500 Message-ID: <50AFB749.8090507@oracle.com> Date: Fri, 23 Nov 2012 11:50:01 -0600 From: Dave Kleikamp User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121029 Thunderbird/16.0.2 MIME-Version: 1.0 To: Christoph Hellwig CC: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Zach Brown , "Maxim V. Patlasov" , Mel Gorman , Trond Myklebust , linux-nfs@vger.kernel.org, Rik van Riel Subject: Re: [PATCH v4 23/31] nfs: simplify swap References: <1353537671-26284-1-git-send-email-dave.kleikamp@oracle.com> <1353537671-26284-24-git-send-email-dave.kleikamp@oracle.com> <20121123082157.GC10731@infradead.org> In-Reply-To: <20121123082157.GC10731@infradead.org> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/23/2012 02:21 AM, Christoph Hellwig wrote: > On Wed, Nov 21, 2012 at 04:41:03PM -0600, Dave Kleikamp wrote: >> swap_writepage can now call nfs's write_iter f_op, eliminating the need to >> implement for the special-case direct_IO a_op. There is no longer a need to >> pass the uio flag through the direct write path. > > This should also kill off the nasty REQ_KERNEL flag. Right. Missed that. Shaggy