From: "Suzuki K. Poulose" <suzuki@in.ibm.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: bigeasy@linutronix.de, ananth@in.ibm.com,
srikar@linux.vnet.ibm.com, peterz@infradead.org,
benh@kernel.crashing.org, mingo@elte.hu, anton@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] uprobes/powerpc: Make use of generic routines to enable single step
Date: Tue, 27 Nov 2012 10:26:40 +0530 [thread overview]
Message-ID: <50B44808.3000704@in.ibm.com> (raw)
In-Reply-To: <20121126170135.GA8668@redhat.com>
On 11/26/2012 10:31 PM, Oleg Nesterov wrote:
> On 11/26, Suzuki K. Poulose wrote:
>>
>> @@ -121,8 +125,11 @@ int arch_uprobe_post_xol(struct arch_uprobe *auprobe, struct pt_regs *regs)
>> * to be executed.
>> */
>> regs->nip = utask->vaddr + MAX_UINSN_BYTES;
>> + regs->msr = utask->autask.saved_msr;
>> +#ifdef CONFIG_PPC_ADV_DEBUG_REGS
>> + mtspr(SPRN_DBCR0, utask->autask.saved_dbcr);
>> +#endif
>>
>> - user_disable_single_step(current);
>
> Don't we need the same change in arch_uprobe_abort_xol() ?
Yes, we do. Thanks for catching that. I will fix it.
Thanks for the review.
Suzuki
prev parent reply other threads:[~2012-11-27 4:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 11:04 [PATCH 0/2] uprobes/powerpc: Replace ptrace single step helpers Suzuki K. Poulose
2012-11-26 11:05 ` [PATCH 1/2] powerpc: Move the single step enable code to a generic path Suzuki K. Poulose
2012-11-26 18:10 ` Sebastian Andrzej Siewior
2012-11-27 9:18 ` Suzuki K. Poulose
2012-11-26 11:06 ` [PATCH 2/2] uprobes/powerpc: Make use of generic routines to enable single step Suzuki K. Poulose
2012-11-26 17:01 ` Oleg Nesterov
2012-11-27 4:56 ` Suzuki K. Poulose [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B44808.3000704@in.ibm.com \
--to=suzuki@in.ibm.com \
--cc=ananth@in.ibm.com \
--cc=anton@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox