From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752768Ab2K1DPZ (ORCPT ); Tue, 27 Nov 2012 22:15:25 -0500 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:39377 "EHLO e23smtp09.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752294Ab2K1DPX (ORCPT ); Tue, 27 Nov 2012 22:15:23 -0500 Message-ID: <50B581C1.2050406@linux.vnet.ibm.com> Date: Wed, 28 Nov 2012 11:15:13 +0800 From: Xiao Guangrong User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Marcelo Tosatti CC: Avi Kivity , LKML , KVM Subject: Re: [PATCH 2/3] KVM: x86: let reexecute_instruction work for tdp References: <50AAC77C.8040505@linux.vnet.ibm.com> <50AAC7CE.2050506@linux.vnet.ibm.com> <20121126223712.GA10634@amt.cnet> <50B42FC7.2080805@linux.vnet.ibm.com> <20121127233246.GB8295@amt.cnet> In-Reply-To: <20121127233246.GB8295@amt.cnet> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit x-cbid: 12112803-3568-0000-0000-000002D64D8F Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/28/2012 07:32 AM, Marcelo Tosatti wrote: > On Tue, Nov 27, 2012 at 11:13:11AM +0800, Xiao Guangrong wrote: >>>> +static bool reexecute_instruction(struct kvm_vcpu *vcpu, unsigned long cr2) >>>> { >>>> - gpa_t gpa; >>>> + gpa_t gpa = cr2; >>>> pfn_t pfn; >>>> >>>> - if (tdp_enabled) >>>> + if (!ACCESS_ONCE(vcpu->kvm->arch.indirect_shadow_pages)) >>>> return false; >>> >>> How is indirect_shadow_pages protected? Why is ACCESS_ONCE() being used >>> to read it? >> >> Hi Marcelo, >> >> It is protected by mmu-lock for it only be changed when mmu-lock is hold. And >> ACCESS_ONCE is used on read path avoiding magic optimization from compiler. > > Please switch to mmu_lock protection, there is no reason to have access > to this variable locklessly - not performance critical. > > For example, there is no use of barriers when modifying the variable. This is not bad, the worst case is, the direct mmu failed to unprotect the shadow pages, (meet indirect_shadow_pages = 0, but there has shadow pages being shadowed.), after enter to guest, we will go into reexecute_instruction again, then it will remove shadow pages. But, i do not have strong opinion on it, i respect your idea! :)