public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frank Rowand <frank.rowand@am.sony.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: <linux-kernel@vger.kernel.org>, <linux-rt-users@vger.kernel.org>,
	<grant.likely@secretlab.ca>
Subject: 3.6.7-rt18 ARM BUG_ON() at kernel/sched/core.c:3817
Date: Wed, 28 Nov 2012 19:31:42 -0800	[thread overview]
Message-ID: <50B6D71E.30003@am.sony.com> (raw)

3.6.7-rt18:  kernel BUG at .../kernel/sched/core.c:3817!

Grant reported this same problem for 3.6.5-rt15.

I am seeing it on a different arm board.

Here is the BUG_ON():

   asmlinkage void __sched preempt_schedule_irq(void)
   {
        struct thread_info *ti = current_thread_info();

        /* Catch callers which need to be fixed */
        BUG_ON(ti->preempt_count || !irqs_disabled());

Putting in some extra printk(), the BUG_ON() is triggering because
ti->preempt_count is non-zero.


It appears that the cause is in arch/arm/kernel/entry-armv.S.

The call to preempt_schedule_irq() is from svc_preempt:

   #ifdef CONFIG_PREEMPT
   svc_preempt:
           mov     r8, lr
   1:      bl      preempt_schedule_irq            @ irq en/disable is done inside


svc_preempt is branched to from one of two possible places.  The first was
present before the lazy preempt code was added.  The first appears ok to me.
(Note that the first branch does not occur if preempt count is non-zero.)

The second branch can occur even if the preempt count is non-zero (which is
what the BUG_ON() is finding):

   __irq_svc:
           svc_entry
           irq_handler

   #ifdef CONFIG_PREEMPT
           get_thread_info tsk
           ldr     r8, [tsk, #TI_PREEMPT]          @ get preempt count
           ldr     r0, [tsk, #TI_FLAGS]            @ get flags
           teq     r8, #0                          @ if preempt count != 0
           movne   r0, #0                          @ force flags to 0
           tst     r0, #_TIF_NEED_RESCHED
           blne    svc_preempt
           ldr     r8, [tsk, #TI_PREEMPT_LAZY]     @ get preempt lazy count
           ldr     r0, [tsk, #TI_FLAGS]            @ get flags
           teq     r8, #0                          @ if preempt lazy count != 0
           movne   r0, #0                          @ force flags to 0
           tst     r0, #_TIF_NEED_RESCHED_LAZY
           blne    svc_preempt
   #endif






             reply	other threads:[~2012-11-29  3:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-29  3:31 Frank Rowand [this message]
2012-11-29 19:52 ` 3.6.7-rt18 ARM BUG_ON() at kernel/sched/core.c:3817 Frank Rowand
2012-11-30  9:22 ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50B6D71E.30003@am.sony.com \
    --to=frank.rowand@am.sony.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox