From: Abhijit Pawar <abhi.c.pawar@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Abhijit Pawar <abhi.c.pawar@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] fs:sysfs pass NULL as second parameter for set_anon_super
Date: Fri, 30 Nov 2012 11:02:12 +0530 [thread overview]
Message-ID: <50B844DC.308@gmail.com> (raw)
In-Reply-To: <20121129153639.GA6639@kroah.com>
On 11/29/2012 09:06 PM, Greg Kroah-Hartman wrote:
> On Thu, Nov 29, 2012 at 12:05:45PM +0530, Abhijit Pawar wrote:
>> set_anon_super does not use the second parameter in its implementation.
>> So there is no need to pass on the second parameter.
>
> Why not just remove the second parameter from the call then?
>
> thanks,
>
> greg k-h
>
This is used as a callback function. So changing the signature will
affect many other filesystems who use the default function rather than
the overridden one.
--
-
Abhijit
prev parent reply other threads:[~2012-11-30 5:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 6:35 [PATCH 6/6] fs:sysfs pass NULL as second parameter for set_anon_super Abhijit Pawar
2012-11-29 15:36 ` Greg Kroah-Hartman
2012-11-30 5:32 ` Abhijit Pawar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B844DC.308@gmail.com \
--to=abhi.c.pawar@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).