From: Laxman Dewangan <ldewangan@nvidia.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: tps51632: Ensure [base|max]_voltage_uV pdata settings are valid
Date: Sat, 1 Dec 2012 01:30:48 +0530 [thread overview]
Message-ID: <50B91070.9080708@nvidia.com> (raw)
In-Reply-To: <1354265569.3859.1.camel@phoenix>
On Friday 30 November 2012 02:22 PM, Axel Lin wrote:
> If pdata->base_voltage_uV is missing or the settings of pdata->base_voltage_uV
> and pdata->max_voltage_uV are out of range, TPS51632_VOLT_VSEL macro
> returns wrong vsel.
>
> Thus add checking [base|max]_voltage_uV pdata settings in probe.
>
Looks good.
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
next prev parent reply other threads:[~2012-11-30 20:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 8:52 [PATCH] regulator: tps51632: Ensure [base|max]_voltage_uV pdata settings are valid Axel Lin
2012-11-30 20:00 ` Laxman Dewangan [this message]
2012-12-02 15:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B91070.9080708@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=axel.lin@ingics.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox