From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753247Ab2LAS5I (ORCPT ); Sat, 1 Dec 2012 13:57:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:23611 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752761Ab2LAS5H (ORCPT ); Sat, 1 Dec 2012 13:57:07 -0500 Message-ID: <50BA52B6.2010009@redhat.com> Date: Sat, 01 Dec 2012 13:55:50 -0500 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Linus Torvalds CC: Ingo Molnar , Linux Kernel Mailing List , linux-mm , Peter Zijlstra , Paul Turner , Lee Schermerhorn , Christoph Lameter , Mel Gorman , Andrew Morton , Andrea Arcangeli , Thomas Gleixner , Johannes Weiner , Hugh Dickins Subject: Re: [RFC PATCH] mm/migration: Remove anon vma locking from try_to_unmap() use References: <1354305521-11583-1-git-send-email-mingo@kernel.org> <20121201094927.GA12366@gmail.com> <20121201122649.GA20322@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/01/2012 01:38 PM, Linus Torvalds wrote: > On Sat, Dec 1, 2012 at 4:26 AM, Ingo Molnar wrote: >> >> >> So as a quick concept hack I wrote the patch attached below. >> (It's not signed off, see the patch description text for the >> reason.) > > Well, it confirms that anon_vma locking is a big problem, but as > outlined in my other email it's completely incorrect from an actual > behavior standpoint. > > Btw, I think the anon_vma lock could be made a spinlock The anon_vma lock used to be a spinlock, and was turned into a mutex by Peter, as part of an effort to make more of the VM preemptible. -- All rights reversed