From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751376Ab2LCWTQ (ORCPT ); Mon, 3 Dec 2012 17:19:16 -0500 Received: from mms2.broadcom.com ([216.31.210.18]:4131 "EHLO mms2.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751079Ab2LCWTP (ORCPT ); Mon, 3 Dec 2012 17:19:15 -0500 X-Server-Uuid: 4500596E-606A-40F9-852D-14843D8201B2 Message-ID: <50BD24DB.7090501@broadcom.com> Date: Mon, 3 Dec 2012 14:16:59 -0800 From: "Bhanu Prakash Gollapudi" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 To: "Cyril Roelandt" cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, JBottomley@parallels.com, linux-scsi@vger.kernel.org Subject: Re: [PATCH 3/6] scsi: bnx2fc: remove useless calls to memset(). References: <1354416022-20189-1-git-send-email-tipecaml@gmail.com> <1354416022-20189-4-git-send-email-tipecaml@gmail.com> In-Reply-To: <1354416022-20189-4-git-send-email-tipecaml@gmail.com> X-WSS-ID: 7CA3FB3B3R014178509-01-01 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/01/2012 06:40 PM, Cyril Roelandt wrote: > These calls are followed by calls to memcpy() on the same memory area, so they > can be safely removed. > > Signed-off-by: Cyril Roelandt > --- > drivers/scsi/bnx2fc/bnx2fc_hwi.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/scsi/bnx2fc/bnx2fc_hwi.c b/drivers/scsi/bnx2fc/bnx2fc_hwi.c > index ef60afa..9be42b8 100644 > --- a/drivers/scsi/bnx2fc/bnx2fc_hwi.c > +++ b/drivers/scsi/bnx2fc/bnx2fc_hwi.c > @@ -759,8 +759,6 @@ static void bnx2fc_process_unsol_compl(struct bnx2fc_rport *tgt, u16 wqe) > case FCOE_ERROR_CODE_DATA_SOFN_SEQ_ACTIVE_RESET: > BNX2FC_TGT_DBG(tgt, "REC TOV popped for xid - 0x%x\n", > xid); > - memset(&io_req->err_entry, 0, > - sizeof(struct fcoe_err_report_entry)); > memcpy(&io_req->err_entry, err_entry, > sizeof(struct fcoe_err_report_entry)); > if (!test_bit(BNX2FC_FLAG_SRR_SENT, > @@ -847,8 +845,6 @@ ret_err_rqe: > goto ret_warn_rqe; > } > > - memset(&io_req->err_entry, 0, > - sizeof(struct fcoe_err_report_entry)); > memcpy(&io_req->err_entry, err_entry, > sizeof(struct fcoe_err_report_entry)); > Acked-by: Bhanu Prakash Gollapudi