From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Vitaly Andrianov <vitalya@ti.com>
Cc: <mina86@mina86.com>, <m.szyprowski@samsung.com>,
<kyungmin.park@samsung.com>, <arnd@arndb.de>,
<linux-kernel@vger.kernel.org>, <linux-keystone@list.ti.com>,
Cyril Chemparathy <cyril@ti.com>
Subject: Re: [linux-keystone] [PATCH v2] drivers: cma: fix addressing on PAE machines
Date: Tue, 4 Dec 2012 12:16:29 +0530 [thread overview]
Message-ID: <50BD9C45.7070501@ti.com> (raw)
In-Reply-To: <1354549570-21445-1-git-send-email-vitalya@ti.com>
On Monday 03 December 2012 09:16 PM, Vitaly Andrianov wrote:
> This patch fixes a couple of bugs that otherwise impair CMA functionality on
> PAE machines:
>
> - alignment must be a 64-bit type when running on systems with 64-bit
> physical addresses. If this is not the case, the limit calculation thunks
> allocations down to an address range < 4G.
>
> - The allocated range check is removed. On 32bit ARM kernel with LPAE
> enabled the base may be allocated outside the fist 4GB of physical
> memory (keystone SoC for example).
>
Any reason you have clubbed two fixes in one patch. Its better to keep
the two fixes separate patches.
> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
> Signed-off-by: Cyril Chemparathy <cyril@ti.com>
> ---
Other than that, patch looks good to my eyes.
Regards,
Santosh
next prev parent reply other threads:[~2012-12-04 6:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 15:46 [PATCH v2] drivers: cma: fix addressing on PAE machines Vitaly Andrianov
2012-12-03 18:19 ` Michal Nazarewicz
2012-12-04 6:46 ` Santosh Shilimkar [this message]
2012-12-04 13:07 ` [linux-keystone] " Michal Nazarewicz
2012-12-04 15:00 ` Santosh Shilimkar
2012-12-04 19:04 ` Michal Nazarewicz
2012-12-04 21:03 ` Andrianov, Vitaly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BD9C45.7070501@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=arnd@arndb.de \
--cc=cyril@ti.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-keystone@list.ti.com \
--cc=m.szyprowski@samsung.com \
--cc=mina86@mina86.com \
--cc=vitalya@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox