From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751204Ab2LDGqT (ORCPT ); Tue, 4 Dec 2012 01:46:19 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:49340 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750826Ab2LDGqS (ORCPT ); Tue, 4 Dec 2012 01:46:18 -0500 Message-ID: <50BD9C45.7070501@ti.com> Date: Tue, 4 Dec 2012 12:16:29 +0530 From: Santosh Shilimkar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Vitaly Andrianov CC: , , , , , , Cyril Chemparathy Subject: Re: [linux-keystone] [PATCH v2] drivers: cma: fix addressing on PAE machines References: <1354549570-21445-1-git-send-email-vitalya@ti.com> In-Reply-To: <1354549570-21445-1-git-send-email-vitalya@ti.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 03 December 2012 09:16 PM, Vitaly Andrianov wrote: > This patch fixes a couple of bugs that otherwise impair CMA functionality on > PAE machines: > > - alignment must be a 64-bit type when running on systems with 64-bit > physical addresses. If this is not the case, the limit calculation thunks > allocations down to an address range < 4G. > > - The allocated range check is removed. On 32bit ARM kernel with LPAE > enabled the base may be allocated outside the fist 4GB of physical > memory (keystone SoC for example). > Any reason you have clubbed two fixes in one patch. Its better to keep the two fixes separate patches. > Signed-off-by: Vitaly Andrianov > Signed-off-by: Cyril Chemparathy > --- Other than that, patch looks good to my eyes. Regards, Santosh