From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752962Ab2LDJfK (ORCPT ); Tue, 4 Dec 2012 04:35:10 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:39187 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751090Ab2LDJfF (ORCPT ); Tue, 4 Dec 2012 04:35:05 -0500 X-IronPort-AV: E=Sophos;i="4.83,370,1352044800"; d="scan'208";a="6330031" Message-ID: <50BDC38C.1060209@cn.fujitsu.com> Date: Tue, 04 Dec 2012 17:34:04 +0800 From: Tang Chen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Wen Congyang CC: x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, sparclinux@vger.kernel.org, David Rientjes , Jiang Liu , Len Brown , benh@kernel.crashing.org, paulus@samba.org, Christoph Lameter , Minchan Kim , Andrew Morton , KOSAKI Motohiro , Yasuaki Ishimatsu , Jianguo Wu Subject: Re: [Patch v4 06/12] memory-hotplug: unregister memory section on SPARSEMEM_VMEMMAP References: <1354010422-19648-1-git-send-email-wency@cn.fujitsu.com> <1354010422-19648-7-git-send-email-wency@cn.fujitsu.com> In-Reply-To: <1354010422-19648-7-git-send-email-wency@cn.fujitsu.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/12/04 17:34:25, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/12/04 17:34:26, Serialize complete at 2012/12/04 17:34:26 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/27/2012 06:00 PM, Wen Congyang wrote: > From: Yasuaki Ishimatsu > > Currently __remove_section for SPARSEMEM_VMEMMAP does nothing. But even if > we use SPARSEMEM_VMEMMAP, we can unregister the memory_section. > > So the patch add unregister_memory_section() into __remove_section(). > > CC: David Rientjes > CC: Jiang Liu > CC: Len Brown > CC: Christoph Lameter > Cc: Minchan Kim > CC: Andrew Morton > CC: KOSAKI Motohiro > Signed-off-by: Yasuaki Ishimatsu > Signed-off-by: Wen Congyang __remove_section() of CONFIG_SPARSEMEM_VMEMMAP will be integrated into one in [PATCH 08/12], so I think we can merge this patch into [PATCH 08/12]. Reviewed-by: Tang Chen > --- > mm/memory_hotplug.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index e741732..171610d 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -279,11 +279,14 @@ static int __meminit __add_section(int nid, struct zone *zone, > #ifdef CONFIG_SPARSEMEM_VMEMMAP > static int __remove_section(struct zone *zone, struct mem_section *ms) > { > - /* > - * XXX: Freeing memmap with vmemmap is not implement yet. > - * This should be removed later. > - */ > - return -EBUSY; > + int ret = -EINVAL; > + > + if (!valid_section(ms)) > + return ret; > + > + ret = unregister_memory_section(ms); > + > + return ret; > } > #else > static int __remove_section(struct zone *zone, struct mem_section *ms)