From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424604Ab2LFRQn (ORCPT ); Thu, 6 Dec 2012 12:16:43 -0500 Received: from mail-lb0-f174.google.com ([209.85.217.174]:43643 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424543Ab2LFRQl (ORCPT ); Thu, 6 Dec 2012 12:16:41 -0500 Message-ID: <50C0E0E8.3020809@mvista.com> Date: Thu, 06 Dec 2012 21:16:08 +0300 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Wenyou Yang CC: linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, JM.Lin@atmel.com, nicolas.ferre@atmel.com, linux-kernel@vger.kernel.org, wim@iguana.be, plagnioj@jcrosoft.com Subject: Re: [v2 PATCH 6/8] watchdog/at91sam9_wdt: Use module_platform_driver() References: <1354671267-19277-1-git-send-email-wenyou.yang@atmel.com> <1354671267-19277-7-git-send-email-wenyou.yang@atmel.com> In-Reply-To: <1354671267-19277-7-git-send-email-wenyou.yang@atmel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 12/05/2012 04:34 AM, Wenyou Yang wrote: > Using module_platform_driver() replaces module_init() and module_exit() > and makes the code simpler. > Signed-off-by: Wenyou Yang > Cc: wim@iguana.be > Cc: linux-watchdog@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/watchdog/at91sam9_wdt.c | 14 ++------------ > 1 file changed, 2 insertions(+), 12 deletions(-) > > diff --git a/drivers/watchdog/at91sam9_wdt.c b/drivers/watchdog/at91sam9_wdt.c > index 5afd3fb..a7c0881 100644 > --- a/drivers/watchdog/at91sam9_wdt.c > +++ b/drivers/watchdog/at91sam9_wdt.c > @@ -278,6 +278,7 @@ MODULE_DEVICE_TABLE(of, at91_wdt_dt_ids); > #endif > > static struct platform_driver at91wdt_driver = { > + .probe = at91wdt_probe, You also need to remove '__init' annotation from that function since the driver becomes hot-plug aware now. WBR, Sergei