From: Patrick Trantham <patrick.trantham@fuel7.com>
To: Cong Ding <dinggnu@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Otavio Salvador <otavio@ossystems.com.br>,
Javier Martinez Canillas <javier@dowhile0.org>,
Jiri Kosina <jkosina@suse.cz>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix initializer entry defined twice issue
Date: Thu, 06 Dec 2012 17:59:21 -0600 [thread overview]
Message-ID: <50C13159.2070901@fuel7.com> (raw)
In-Reply-To: <1354835928-617-1-git-send-email-dinggnu@gmail.com>
On 12/06/2012 05:16 PM, Cong Ding wrote:
> the ".config_intr" is defined twice in both line 208 and 212.
>
> Signed-off-by: Cong Ding <dinggnu@gmail.com>
> ---
> drivers/net/phy/smsc.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c
> index 16dceed..5cee6bd 100644
> --- a/drivers/net/phy/smsc.c
> +++ b/drivers/net/phy/smsc.c
> @@ -205,7 +205,6 @@ static struct phy_driver smsc_phy_driver[] = {
> /* basic functions */
> .config_aneg = genphy_config_aneg,
> .read_status = lan87xx_read_status,
> - .config_intr = smsc_phy_config_intr,
>
> /* IRQ related */
> .ack_interrupt = smsc_phy_ack_interrupt,
Hi Cong,
That looks like a mistake from my previous patch to that file. Copy and
paste fail.
The line should read:
.config_init = smsc_phy_config_init,
I can submit a patch once I get off work unless you beat me to it.
regards,
Patrick
next prev parent reply other threads:[~2012-12-07 0:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 23:16 [PATCH] fix initializer entry defined twice issue Cong Ding
2012-12-06 23:59 ` Patrick Trantham [this message]
2012-12-07 0:05 ` Cong Ding
2012-12-07 19:51 ` Patrick Trantham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C13159.2070901@fuel7.com \
--to=patrick.trantham@fuel7.com \
--cc=davem@davemloft.net \
--cc=dinggnu@gmail.com \
--cc=javier@dowhile0.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox