From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422807Ab2LGAZT (ORCPT ); Thu, 6 Dec 2012 19:25:19 -0500 Received: from mail.fuel7.com ([74.222.0.51]:43607 "EHLO mail.fuel7.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755011Ab2LGAZS (ORCPT ); Thu, 6 Dec 2012 19:25:18 -0500 X-Greylist: delayed 1548 seconds by postgrey-1.27 at vger.kernel.org; Thu, 06 Dec 2012 19:25:18 EST Message-ID: <50C13159.2070901@fuel7.com> Date: Thu, 06 Dec 2012 17:59:21 -0600 From: Patrick Trantham User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Cong Ding CC: "David S. Miller" , Otavio Salvador , Javier Martinez Canillas , Jiri Kosina , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fix initializer entry defined twice issue References: <1354835928-617-1-git-send-email-dinggnu@gmail.com> In-Reply-To: <1354835928-617-1-git-send-email-dinggnu@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/06/2012 05:16 PM, Cong Ding wrote: > the ".config_intr" is defined twice in both line 208 and 212. > > Signed-off-by: Cong Ding > --- > drivers/net/phy/smsc.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c > index 16dceed..5cee6bd 100644 > --- a/drivers/net/phy/smsc.c > +++ b/drivers/net/phy/smsc.c > @@ -205,7 +205,6 @@ static struct phy_driver smsc_phy_driver[] = { > /* basic functions */ > .config_aneg = genphy_config_aneg, > .read_status = lan87xx_read_status, > - .config_intr = smsc_phy_config_intr, > > /* IRQ related */ > .ack_interrupt = smsc_phy_ack_interrupt, Hi Cong, That looks like a mistake from my previous patch to that file. Copy and paste fail. The line should read: .config_init = smsc_phy_config_init, I can submit a patch once I get off work unless you beat me to it. regards, Patrick