Re: [PATCH 2/4] mfd: 88pm80x: move to regmap irq base implementation

[Qing Xu <qingx@marvell.com>]

On 12/03/2012 01:40 PM, Qing Xu wrote:
> From: Qing Xu <qingx@marvell.com>
>
> get irq_base for mfd sub-device
>
> Signed-off-by: Qiao Zhou <zhouqiao@marvell.com>
> Signed-off-by: Qing Xu <qingx@marvell.com>
> ---
>   drivers/mfd/88pm800.c       |    2 +-
>   drivers/mfd/88pm805.c       |    1 +
>   include/linux/mfd/88pm80x.h |    1 +
>   3 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c
> index 73b2c9f..e1525ab 100644
> --- a/drivers/mfd/88pm800.c
> +++ b/drivers/mfd/88pm800.c
> @@ -343,7 +343,7 @@ static int __devinit device_irq_init_800(struct pm80x_chip *chip)
>   	ret =
>   	    regmap_add_irq_chip(chip->regmap, chip->irq, flags, -1,
>   				chip->regmap_irq_chip, &chip->irq_data);
> -
> +	chip->irq_base = regmap_irq_chip_get_base(chip->irq_data);
>   out:
>   	return ret;
>   }
> diff --git a/drivers/mfd/88pm805.c b/drivers/mfd/88pm805.c
> index 7878013..8c9e25a 100644
> --- a/drivers/mfd/88pm805.c
> +++ b/drivers/mfd/88pm805.c
> @@ -168,6 +168,7 @@ static int __devinit device_irq_init_805(struct pm80x_chip *chip)
>   	ret =
>   	    regmap_add_irq_chip(chip->regmap, chip->irq, flags, -1,
>   				chip->regmap_irq_chip, &chip->irq_data);
> +	chip->irq_base = regmap_irq_chip_get_base(chip->irq_data);
>   out:
>   	return ret;
>   }
> diff --git a/include/linux/mfd/88pm80x.h b/include/linux/mfd/88pm80x.h
> index a0ca0dc..904efb9 100644
> --- a/include/linux/mfd/88pm80x.h
> +++ b/include/linux/mfd/88pm80x.h
> @@ -303,6 +303,7 @@ struct pm80x_chip {
>   	int id;
>   	int irq;
>   	int irq_mode;
> +	int irq_base;
>   	unsigned long wu_flag;
>   	spinlock_t lock;
>   };


Samuel,

Could you help to review my patch? Thanks a lot!

Qing