[PATCH] USB: adds support for Novatek wireless mouse to usbhid

[PATCH] USB: adds support for Novatek wireless mouse to usbhid

[Benoit Touchette]

This patch adds support for the Novatek wireless mouse (device id
0603:1602) to usbhid and fixes bug
https://bugzilla.kernel.org/show_bug.cgi?id=47031

Reported-by: Benoit Touchette <draekko.dev@gmail.com>
Signed-off-by: Benoit Touchette <draekko.dev@gmail.com>

---

--- linux-3.6.10/drivers/hid/hid-ids.h.orig    2012-12-10
14:13:27.000000000 -0500
+++ linux-3.6.10/drivers/hid/hid-ids.h    2012-12-12 20:06:41.000000000 -0500
@@ -833,4 +833,7 @@
 #define USB_VENDOR_ID_PRIMAX    0x0461
 #define USB_DEVICE_ID_PRIMAX_KEYBOARD    0x4e05

+#define USB_VENDOR_ID_NOVATEK    0x0603
+#define USB_DEVICE_ID_NOVATEK_MOUSE    0x1602
+
 #endif
--- linux-3.6.10/drivers/hid/usbhid/hid-quirks.c.orig    2012-12-10
14:13:27.000000000 -0500
+++ linux-3.6.10/drivers/hid/usbhid/hid-quirks.c    2012-12-12
20:06:41.000000000 -0500
@@ -98,6 +98,8 @@ static const struct hid_blacklist {

     { USB_VENDOR_ID_PI_ENGINEERING,
USB_DEVICE_ID_PI_ENGINEERING_VEC_USB_FOOTPEDAL,
HID_QUIRK_HIDINPUT_FORCE },

+    { USB_VENDOR_ID_NOVATEK, USB_DEVICE_ID_NOVATEK_MOUSE,
HID_QUIRK_NO_INIT_REPORTS },
+
     { USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_CHICONY_MULTI_TOUCH,
HID_QUIRK_MULTI_INPUT },
     { USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_CHICONY_WIRELESS,
HID_QUIRK_MULTI_INPUT },
     { USB_VENDOR_ID_SIGMA_MICRO, USB_DEVICE_ID_SIGMA_MICRO_KEYBOARD,
HID_QUIRK_NO_INIT_REPORTS },

Re: [PATCH] USB: adds support for Novatek wireless mouse to usbhid

[Greg KH]

On Wed, Dec 12, 2012 at 08:43:32PM -0500, Benoit Touchette wrote:
> This patch adds support for the Novatek wireless mouse (device id
> 0603:1602) to usbhid and fixes bug
> https://bugzilla.kernel.org/show_bug.cgi?id=47031
> 
> Reported-by: Benoit Touchette <draekko.dev@gmail.com>
> Signed-off-by: Benoit Touchette <draekko.dev@gmail.com>
> 
> ---
> 
> --- linux-3.6.10/drivers/hid/hid-ids.h.orig    2012-12-10
> 14:13:27.000000000 -0500
> +++ linux-3.6.10/drivers/hid/hid-ids.h    2012-12-12 20:06:41.000000000 -0500

Please use the scripts/get_maintainer.pl tool to send this patch to the
correct people and mailing list.

Also, your patch is line-wrapped, and can't be applied, you need to look
into fixing your email client to not do this if you wish to get patches
accepted.

greg k-h

Re: [PATCH] USB: adds support for Novatek wireless mouse to usbhid

[draekko.dev]

I followed what was listed here
http://www.kernel.org/doc/Documentation/SubmittingPatches i won't be
resubmitting, i've already spent way too much time for a few lines of
code, I've already been through this with the Ubuntu guys amongst other
reasons. I can email you the file as attachment but that's the extent of
my involvement at this point.

Wishing you y'all a nice evening,
Ben

PS. Resubmitting this email as it for some reason was only sent to Greg.

On Wed, Dec 12, 2012 at 8:50 PM, Greg KH <greg@kroah.com> wrote:
> On Wed, Dec 12, 2012 at 08:43:32PM -0500, Benoit Touchette wrote:
>> This patch adds support for the Novatek wireless mouse (device id
>> 0603:1602) to usbhid and fixes bug
>> https://bugzilla.kernel.org/show_bug.cgi?id=47031
>>
>> Reported-by: Benoit Touchette <draekko.dev@gmail.com>
>> Signed-off-by: Benoit Touchette <draekko.dev@gmail.com>
>>
>> ---
>>
>> --- linux-3.6.10/drivers/hid/hid-ids.h.orig    2012-12-10
>> 14:13:27.000000000 -0500
>> +++ linux-3.6.10/drivers/hid/hid-ids.h    2012-12-12 20:06:41.000000000 -0500
>
> Please use the scripts/get_maintainer.pl tool to send this patch to the
> correct people and mailing list.
>
> Also, your patch is line-wrapped, and can't be applied, you need to look
> into fixing your email client to not do this if you wish to get patches
> accepted.
>
> greg k-h

Re: [PATCH] USB: adds support for Novatek wireless mouse to usbhid

[Jiri Kosina]

On Wed, 12 Dec 2012, draekko.dev wrote:

> I followed what was listed here
> http://www.kernel.org/doc/Documentation/SubmittingPatches 

You did not completely. That document references

	http://www.kernel.org/doc/Documentation/email-clients.txt

and that clearly states that you can't use gmail web interface for in-line 
patch submissions, as it unavoidably corrupts those.

> i won't be resubmitting, 

Well, then you can hardly expect the patch to be applied.

-- 
Jiri Kosina
SUSE Labs

Re: [PATCH] USB: adds support for Novatek wireless mouse to usbhid

[Marco Biscaro]

Em 12-12-2012 23:50, Greg KH escreveu:
> Please use the scripts/get_maintainer.pl tool to send this patch to the
> correct people and mailing list.
>
> Also, your patch is line-wrapped, and can't be applied, you need to look
> into fixing your email client to not do this if you wish to get patches
> accepted.
>
> greg k-h

This patch was already proposed[1] and Jiri Kosina (which is CC'd) said 
"It's queued in my tree, but didn't justify pull request to Linus just 
because of this, so currently it's scheduled for 3.8."

[1] http://permalink.gmane.org/gmane.linux.usb.general/75252