* [PATCH v2] pwm: samsung: add missing s3c->pwm_id
@ 2012-12-14 6:58 Joonyoung Shim
2012-12-14 7:34 ` Thierry Reding
0 siblings, 1 reply; 3+ messages in thread
From: Joonyoung Shim @ 2012-12-14 6:58 UTC (permalink / raw)
To: thierry.reding; +Cc: linux-samsung-soc, linux-kernel, kgene.kim, kyungmin.park
The s3c->pwm_id is used to calculate offset of related register.
Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
---
Changelog from v1:
- move the assignment code to below.
drivers/pwm/pwm-samsung.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c
index 023a3be..0704a2a 100644
--- a/drivers/pwm/pwm-samsung.c
+++ b/drivers/pwm/pwm-samsung.c
@@ -222,6 +222,7 @@ static int s3c_pwm_probe(struct platform_device *pdev)
/* calculate base of control bits in TCON */
s3c->tcon_base = id == 0 ? 0 : (id * 4) + 4;
+ s3c->pwm_id = id;
s3c->chip.dev = &pdev->dev;
s3c->chip.ops = &s3c_pwm_ops;
s3c->chip.base = -1;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] pwm: samsung: add missing s3c->pwm_id
2012-12-14 6:58 [PATCH v2] pwm: samsung: add missing s3c->pwm_id Joonyoung Shim
@ 2012-12-14 7:34 ` Thierry Reding
2012-12-14 7:40 ` Joonyoung Shim
0 siblings, 1 reply; 3+ messages in thread
From: Thierry Reding @ 2012-12-14 7:34 UTC (permalink / raw)
To: Joonyoung Shim; +Cc: linux-samsung-soc, linux-kernel, kgene.kim, kyungmin.park
[-- Attachment #1: Type: text/plain, Size: 361 bytes --]
On Fri, Dec 14, 2012 at 03:58:58PM +0900, Joonyoung Shim wrote:
> The s3c->pwm_id is used to calculate offset of related register.
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
I've modified the subject a bit to make it clear the assignment of
s3c->pwm_id was missing, not the s3c->pwm_id field altogether.
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] pwm: samsung: add missing s3c->pwm_id
2012-12-14 7:34 ` Thierry Reding
@ 2012-12-14 7:40 ` Joonyoung Shim
0 siblings, 0 replies; 3+ messages in thread
From: Joonyoung Shim @ 2012-12-14 7:40 UTC (permalink / raw)
To: Thierry Reding; +Cc: linux-samsung-soc, linux-kernel, kgene.kim, kyungmin.park
On 12/14/2012 04:34 PM, Thierry Reding wrote:
> On Fri, Dec 14, 2012 at 03:58:58PM +0900, Joonyoung Shim wrote:
>> The s3c->pwm_id is used to calculate offset of related register.
>>
>> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> I've modified the subject a bit to make it clear the assignment of
> s3c->pwm_id was missing, not the s3c->pwm_id field altogether.
>
> Applied, thanks.
OK, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-14 7:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-14 6:58 [PATCH v2] pwm: samsung: add missing s3c->pwm_id Joonyoung Shim
2012-12-14 7:34 ` Thierry Reding
2012-12-14 7:40 ` Joonyoung Shim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox