From: Konstantin Khlebnikov <khlebnikov@openvz.org>
To: Borislav Petkov <bp@alien8.de>,
linux-kernel@vger.kernel.org, Jeff Garzik <jgarzik@redhat.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] ata: uncomment ata_timing for XFER_PIO_SLOW
Date: Fri, 14 Dec 2012 15:45:49 +0400 [thread overview]
Message-ID: <50CB116D.7050701@openvz.org> (raw)
In-Reply-To: <20121214111351.GA7307@liondog.tnic>
Borislav Petkov wrote:
> On Fri, Dec 14, 2012 at 03:01:37PM +0400, Konstantin Khlebnikov wrote:
>> This patch uncomments ata timings for XFER_PIO_SLOW,
>> otherwise ata_timing_find_mode() returns NULL and kernel crashes in
>> pacpi_set_dmamode() after null-pointer dereference.
>>
>> The same problem was mentioned recently in debug patch v3.7-rc5-72-gcd705d5
>> ("libata debugging: Warn when unable to find timing descriptor based on xfer_mode")
>>
>> I'm not sure about this patch, because I have no idea what this XFER_PIO_SLOW
>
> No, this is already fixed by:
>
>
> Btw, this patch will go to stable since I can't find it in 3.7, I'm
> guessing Jeff will send it to Linus soonish since it is in his NEXT
> branch.
>
> Until that happens, you could test 3.7 by cherrypicking the patch above
> ontop of it or by simply applying it by hand since it is only two lines.
>
> Or, you could wait and test -rc1 when it comes out after the world ends :-).
Ah, thanks. Sorry for noise. I'll check this again in current linux-next.
>
>> means and why this bug so rare (3 times during 4 days boot-reboot test) I caught
>> this on completely ordinary PC with nvidia MCP61 chipset, sata hdd and ide dvd-rom.
>>
>> Signed-off-by: Konstantin Khlebnikov<khlebnikov@openvz.org>
>> Signed-off-by: Borislav Petkov<bp@alien8.de>
>> Signed-off-by: Jeff Garzik<jgarzik@redhat.com>
>
> Btw, just FYI, this is not how S-o-b chaining works. Take a look
> at<Documentation/SubmittingPatches> for details on how it is done
> correctly.
ouch :facepalm: how I missed this... just copy-paste error. sorry again.
>
> HTH.
>
next prev parent reply other threads:[~2012-12-14 11:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 11:01 [PATCH] ata: uncomment ata_timing for XFER_PIO_SLOW Konstantin Khlebnikov
2012-12-14 11:13 ` Borislav Petkov
2012-12-14 11:45 ` Konstantin Khlebnikov [this message]
2012-12-14 11:51 ` Borislav Petkov
2012-12-14 11:23 ` Alan Cox
2012-12-14 13:47 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CB116D.7050701@openvz.org \
--to=khlebnikov@openvz.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bp@alien8.de \
--cc=jgarzik@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox