* [PATCH 1/1] scripts/config: Fix wrong "shift" for --keep-case
@ 2012-12-14 6:47 Hiroshi Doyu
2012-12-14 15:21 ` Michal Marek
0 siblings, 1 reply; 2+ messages in thread
From: Hiroshi Doyu @ 2012-12-14 6:47 UTC (permalink / raw)
To: linux-kernel; +Cc: Hiroshi Doyu, Michal Marek, Yann E. MORIN, Andi Kleen
Remove wrong "shift" for --keep-case. There is always "shift" at
beginning of while-loop. No need "shift" at --keep-case just before
"continue" to process next argument.
Now the following works as expected:
./scripts/config -e aAa -k -e bBb -e cCc && tail -3 .config
CONFIG_AAA=y
CONFIG_bBb=y
CONFIG_cCc=y
Signed-off-by: Hiroshi Doyu <hdoyu@nvidia.com>
---
scripts/config | 1 -
1 file changed, 1 deletion(-)
diff --git a/scripts/config b/scripts/config
index ee35539..bb4d3de 100755
--- a/scripts/config
+++ b/scripts/config
@@ -101,7 +101,6 @@ while [ "$1" != "" ] ; do
case "$CMD" in
--keep-case|-k)
MUNGE_CASE=no
- shift
continue
;;
--refresh)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] scripts/config: Fix wrong "shift" for --keep-case
2012-12-14 6:47 [PATCH 1/1] scripts/config: Fix wrong "shift" for --keep-case Hiroshi Doyu
@ 2012-12-14 15:21 ` Michal Marek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Marek @ 2012-12-14 15:21 UTC (permalink / raw)
To: Hiroshi Doyu; +Cc: linux-kernel, Yann E. MORIN, Andi Kleen
On 14.12.2012 07:47, Hiroshi Doyu wrote:
> Remove wrong "shift" for --keep-case. There is always "shift" at
> beginning of while-loop. No need "shift" at --keep-case just before
> "continue" to process next argument.
>
> Now the following works as expected:
>
> ./scripts/config -e aAa -k -e bBb -e cCc && tail -3 .config
> CONFIG_AAA=y
> CONFIG_bBb=y
> CONFIG_cCc=y
>
> Signed-off-by: Hiroshi Doyu <hdoyu@nvidia.com>
Applied to kbuild.git#misc, thanks.
Michal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-14 15:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-14 6:47 [PATCH 1/1] scripts/config: Fix wrong "shift" for --keep-case Hiroshi Doyu
2012-12-14 15:21 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox