From: John Stultz <johnstul@us.ibm.com>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org,
Anton Vorontsov <cbouatmailru@gmail.com>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Anton Vorontsov <anton.vorontsov@linaro.org>
Subject: Re: [PATCH] time: create __getnstimeofday for WARNless calls
Date: Fri, 14 Dec 2012 17:16:51 -0800 [thread overview]
Message-ID: <50CBCF83.30700@us.ibm.com> (raw)
In-Reply-To: <CAGXu5jKdOsBUwZRwOQDeRdFjo-K=uEQdJNMgy4N1dyzrUGcAHw@mail.gmail.com>
On 12/13/2012 10:17 AM, Kees Cook wrote:
> John, any feedback on this?
>
Sorry, yea, I've been meaning to get back to this.
I'm still on the fence about just making getnstimeofday() safe for when
timekeeping is suspended, but at the same time, your issue needs
fixing. Also bailing out at the end still seems off to me. Even if
someone is using the values despite the WARN_ON, they really are getting
junk values, and for all the time that WARN_ON has been there, you're
the first to report running into it.
Even so, I think I'm ok with this patch for now, but I suspect we may
want to rework it later.
Looking at my inbox, I actually can't find a copy of this specific
patch. Do you mind bouncing it to me, so I have something I can apply?
Should this also get marked for -stable?
thanks
-john
next prev parent reply other threads:[~2012-12-15 1:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 18:26 [PATCH] time: create __getnstimeofday for WARNless calls Kees Cook
2012-12-13 18:17 ` Kees Cook
2012-12-15 1:16 ` John Stultz [this message]
2012-12-15 1:17 ` John Stultz
2012-12-15 7:22 ` Kees Cook
-- strict thread matches above, loose matches on Subject: below --
2012-12-17 18:51 John Stultz
2012-12-17 19:28 ` Anton Vorontsov
2012-12-20 11:43 ` Thomas Gleixner
2012-12-20 16:02 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CBCF83.30700@us.ibm.com \
--to=johnstul@us.ibm.com \
--cc=anton.vorontsov@linaro.org \
--cc=cbouatmailru@gmail.com \
--cc=ccross@android.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox