From: Armando Visconti <armando.visconti@st.com>
To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: "balbi@ti.com" <balbi@ti.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Pratyush ANAND <pratyush.anand@st.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
spear-devel <spear-devel@list.st.com>
Subject: Re: [PATCH] usb: gadget zero: avoid unnecessary reinit of data in f_sourcesink
Date: Mon, 17 Dec 2012 18:21:16 +0100 [thread overview]
Message-ID: <50CF548C.2080500@st.com> (raw)
In-Reply-To: <20121217154545.GB5931@breakpoint.cc>
On 12/17/2012 04:45 PM, Sebastian Andrzej Siewior wrote:
> On Thu, Dec 13, 2012 at 03:11:19PM +0100, Armando Visconti wrote:
>> In the IN case, since the USB request is allocated only when
>> the source/sink function is started and never freed, the USB ept
>> buffer needs to be inited only at the beginning. This change
> ^^^^^^
>> results into a more performant g_zero module, especially when
>> 'pattern=1' is selected.
>
> Besides that the patch looks fine :)
Do you mean that 'inited' should be changed with 'initialized'?
Oh ... my poor english... :(
Rgds,
Arm
next prev parent reply other threads:[~2012-12-17 17:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 14:11 [PATCH] usb: gadget zero: avoid unnecessary reinit of data in f_sourcesink Armando Visconti
2012-12-17 15:45 ` Sebastian Andrzej Siewior
2012-12-17 17:21 ` Armando Visconti [this message]
2012-12-18 8:27 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CF548C.2080500@st.com \
--to=armando.visconti@st.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pratyush.anand@st.com \
--cc=sebastian@breakpoint.cc \
--cc=spear-devel@list.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox