public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Tejun Heo <tj@kernel.org>
Cc: Jeff Moyer <jmoyer@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] core block IO bits for 3.8
Date: Mon, 17 Dec 2012 20:07:40 +0100	[thread overview]
Message-ID: <50CF6D7C.2000300@kernel.dk> (raw)
In-Reply-To: <20121217174717.GC2592@htj.dyndns.org>

On 2012-12-17 18:47, Tejun Heo wrote:
> Hello, Jens.
> 
> On Mon, Dec 17, 2012 at 06:04:42PM +0100, Jens Axboe wrote:
>> OK, if you have something generic for threadpools in mind, we can wait
>> with this one. I just thought that a "real" interface was nicer than
>> manual setting, especially since the flusher threads come and go. Then
>> you'd need some udev hook to get it set, not even sure how easy that
>> would be with the weird linkage.
> 
> I've been thinking about this and I think what we really need is a
> generic interface for thread pools where the user can specify various
> attributes - priority, affinity and probably cgroup association, so
> that those attributes are exposed in generic manner while backend
> creates and manages worker pools identified by actual attriutes so
> that we don't end up with gazillion pools.  crypto and writeback would
> be the obvious users and probably the virtio too.  I'll write more
> when things get more concrete.

I agree. That part of the writeback code is pretty generic
functionality.

So new course of action is to revert the commit, and then I'm sure Jeff
will re-send the code to just set the affinity to something sane by
default when that is easily doable.

-- 
Jens Axboe


      reply	other threads:[~2012-12-17 19:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-17 15:34 [GIT PULL] core block IO bits for 3.8 Jens Axboe
2012-12-17 16:06 ` Jeff Moyer
2012-12-17 17:00   ` Tejun Heo
2012-12-17 17:04     ` Jens Axboe
2012-12-17 17:08       ` Linus Torvalds
2012-12-17 17:09         ` Jens Axboe
2012-12-17 17:15       ` Jeff Moyer
2012-12-17 19:06         ` Jens Axboe
2012-12-17 19:27           ` Linus Torvalds
2012-12-17 19:28             ` Jens Axboe
2012-12-17 19:38               ` Shentino
2012-12-17 17:47       ` Tejun Heo
2012-12-17 19:07         ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50CF6D7C.2000300@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox