From: Stephen Warren <swarren@wwwdotorg.org>
To: Venu Byravarasu <vbyravarasu@nvidia.com>
Cc: balbi@ti.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: phy: tegra: Using devm API for memory allocation
Date: Tue, 18 Dec 2012 09:33:11 -0700 [thread overview]
Message-ID: <50D09AC7.9050503@wwwdotorg.org> (raw)
In-Reply-To: <1355811683-29981-1-git-send-email-vbyravarasu@nvidia.com>
On 12/17/2012 11:21 PM, Venu Byravarasu wrote:
> Using devm_kzalloc for allocating memory needed for PHY
> pointer and hence removing kfree calls to PHY pointer.
Since the kfree() here used to be in tegra_usb_phy_close() rather than
any remove() function, does it actually make sense to use
devm_kzalloc(); would plain using kzalloc() instead, and not removing
the kfree() calls, be better?
When the PHY code gets converted to be an actual probed driver, then
perhaps using devm will make sense.
next prev parent reply other threads:[~2012-12-18 16:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 6:21 [PATCH] usb: phy: tegra: Using devm API for memory allocation Venu Byravarasu
2012-12-18 16:33 ` Stephen Warren [this message]
2012-12-19 5:38 ` Venu Byravarasu
2012-12-19 17:38 ` Stephen Warren
2012-12-20 8:48 ` Venu Byravarasu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D09AC7.9050503@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=vbyravarasu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox