From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: djbw@fb.com, vinod.koul@intel.com, linux-kernel@vger.kernel.org,
swarren@nvidia.com, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] dma: tegra: implement flags parameters for cyclic transfer
Date: Wed, 19 Dec 2012 10:02:53 -0700 [thread overview]
Message-ID: <50D1F33D.1050709@wwwdotorg.org> (raw)
In-Reply-To: <1355924434-7930-1-git-send-email-ldewangan@nvidia.com>
On 12/19/2012 06:40 AM, Laxman Dewangan wrote:
> The flag parameter is added in the cyclic transfer request.
> Use the flag option of:
> - DMA_PREP_INTERRUPT for enabling interrupt.
> - DMA_CTRL_ACK for deciding whether ack is requred or not for
> descriptor.
Do the relevant drivers that use Tegra's DMA engine already set flags
correctly, so that this change won't cause any regressions?
Why would you not want to enable interrupts; how does a client know when
to refill the buffer?
next prev parent reply other threads:[~2012-12-19 17:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 13:40 [PATCH] dma: tegra: implement flags parameters for cyclic transfer Laxman Dewangan
2012-12-19 17:02 ` Stephen Warren [this message]
2012-12-20 6:11 ` Laxman Dewangan
2012-12-20 16:46 ` Stephen Warren
2012-12-21 4:23 ` Laxman Dewangan
2012-12-21 20:53 ` Stephen Warren
2013-01-07 13:52 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D1F33D.1050709@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=djbw@fb.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@nvidia.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox