From: Jens Axboe <axboe@kernel.dk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Shaohua Li <shli@fusionio.com>, Neil Brown <neilb@suse.de>,
Ingo Molnar <mingo@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [boot crash] Re: [GIT PULL[ block drivers bits for 3.8
Date: Wed, 19 Dec 2012 19:10:30 +0100 [thread overview]
Message-ID: <50D20316.7020205@kernel.dk> (raw)
In-Reply-To: <CA+55aFx71aA5_eX1=DjKG-Wd0u9YeryD6FeAk9HJ1DnxRTwPoA@mail.gmail.com>
On 2012-12-19 17:29, Linus Torvalds wrote:
>> Of course it's been tested. Granted it got moved over too late (as 1 of
>> 2 that did), but I've run the branch on a multitude of systems.
>> Apparently none of them hit the case of having a zero granularity
>> reported, so never hit the bug.
>
> I presumably happens on pretty much anything that doesn't have
> discard. Of course, I've personally gotten rid of any rotating devices
> I have, but it still sounds like there's a big testing hole somewhere.
It doesn't, though it seems so. Otherwise I definitely would have seen
it. It only happens if discard max sectors is set, but alignment isn't.
I suspect because that first divide is ordered after the
!max_discard_sectors check. At least here.
And I suspect we would have seen a lot more reports if it DID trigger
on anything that didn't have discard :-)
--
Jens Axboe
prev parent reply other threads:[~2012-12-19 18:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 21:08 [GIT PULL[ block drivers bits for 3.8 Jens Axboe
2012-12-18 9:25 ` [boot crash] " Ingo Molnar
2012-12-18 11:42 ` Jens Axboe
2012-12-18 16:49 ` Linus Torvalds
2012-12-19 14:47 ` Jens Axboe
2012-12-19 16:29 ` Linus Torvalds
2012-12-19 17:53 ` Doug Anderson
2012-12-19 18:10 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D20316.7020205@kernel.dk \
--to=axboe@kernel.dk \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=neilb@suse.de \
--cc=shli@fusionio.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).