From: Joonyoung Shim <jy0922.shim@samsung.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linus.walleij@linaro.org, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, kgene.kim@samsung.com,
kyungmin.park@samsung.com
Subject: Re: [PATCH] gpio: samsung: remove exynos_gpio_cfg
Date: Thu, 20 Dec 2012 10:13:54 +0900 [thread overview]
Message-ID: <50D26652.1020205@samsung.com> (raw)
In-Reply-To: <20121219222255.49E263E0AD6@localhost>
Hi Grant,
On 12/20/2012 07:22 AM, Grant Likely wrote:
> On Fri, 14 Dec 2012 19:44:01 +0900, Joonyoung Shim <jy0922.shim@samsung.com> wrote:
>> The exynos_gpio_cfg can be substituted to samsung_gpio_cfgs[8].
>>
>> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> Hi Joonyoung,
>
> I need some help here. I don't understand what this patch is for or how
> it works. The commit text above doesn't give me enough information to
> evaluate the patch. What is the intent here? Why is samsung_gpio_cfgs[8]
> more correct than exynos_gpio_cfg?
First, i just wondered why samsung_gpio_cfgs[8] is used in the
exynos4_gpios_2[] even if exynos_gpio_cfg is exist and found
samsung_gpio_cfgs[8] does same thing with exynos_gpio_cfg. The
exynos_gpio_cfg is used only for Exynos SoCs so it is compiled by #if
defined(CONFIG_ARCH_EXYNOS4) || defined(CONFIG_ARCH_EXYNOS5).
I think one can be removed because they are duplicated codes and it is
better to decrease use of #if defined.
Thanks.
> g.
>
>
prev parent reply other threads:[~2012-12-20 1:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 10:44 [PATCH] gpio: samsung: remove exynos_gpio_cfg Joonyoung Shim
2012-12-14 10:44 ` [PATCH] gpio: samsung: add GPIO interrupt registration for exynos5 Joonyoung Shim
2013-01-17 8:14 ` Linus Walleij
2012-12-14 12:09 ` [PATCH] gpio: samsung: remove exynos_gpio_cfg Tomasz Figa
2012-12-19 22:22 ` Grant Likely
2012-12-20 1:13 ` Joonyoung Shim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D26652.1020205@samsung.com \
--to=jy0922.shim@samsung.com \
--cc=grant.likely@secretlab.ca \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox