From: Sasha Levin <sasha.levin@oracle.com>
To: Tejun Heo <tj@kernel.org>
Cc: Li Zefan <lizefan@huawei.com>,
containers@lists.linux-foundation.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cgroup: remove redundant check
Date: Thu, 20 Dec 2012 14:24:34 -0500 [thread overview]
Message-ID: <50D365F2.7070607@oracle.com> (raw)
In-Reply-To: <20121220191803.GA14527@htj.dyndns.org>
On 12/20/2012 02:18 PM, Tejun Heo wrote:
> On Thu, Dec 20, 2012 at 02:11:31PM -0500, Sasha Levin wrote:
>> We already know that 'event' is non-NULL, remove the redundant check.
>>
>> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
>
> I don't know. I kinda like that test there. It's not an error path
> and tearing down everything which could have been allocated. If the
> test not being used is bothering, convert return -ENOMEM to goto fail?
Can't say it's bothering. If you'd prefer to leave it as is I'm okay with
doing that.
Thanks,
Sasha
next prev parent reply other threads:[~2012-12-20 19:25 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 19:11 [PATCH] tools, power: correct precedence of operators in init_maxfreq_mode Sasha Levin
2012-12-20 19:11 ` [PATCH] kvm tools: remove unneeded checks in qcow code Sasha Levin
2012-12-21 22:03 ` Jesper Juhl
2012-12-20 19:11 ` [PATCH] kvm tools: remove unneeded check from disk code Sasha Levin
2012-12-20 19:11 ` [PATCH] kvm tools: correctly compare pointer with NULL instead of 0 Sasha Levin
2012-12-20 19:11 ` [PATCH] tools lib traceevent: remove redundant check from process_dynamic_array Sasha Levin
2012-12-21 12:58 ` Namhyung Kim
2012-12-20 19:11 ` [PATCH] epoll: stop comparing pointers with 0 in self-test app Sasha Levin
2012-12-21 2:55 ` Daniel Hazelton
2012-12-20 19:11 ` [PATCH] tools/usb: remove unneeded 'continue' and simplify condition Sasha Levin
2012-12-20 20:32 ` Felipe Balbi
2012-12-20 19:11 ` [PATCH] perf kmem: use ARRAY_SIZE instead of reinventing it Sasha Levin
2013-01-25 11:19 ` [tip:perf/core] " tip-bot for Sasha Levin
2012-12-20 19:11 ` [PATCH] cpupowerutils: don't compare pointers with 0 Sasha Levin
2012-12-21 21:41 ` Thomas Renninger
2012-12-20 19:11 ` [PATCH] m2m-deinterlace: use correct check for kzalloc failure Sasha Levin
2012-12-20 19:11 ` [PATCH] perf script: use ARRAY_SIZE instead of reinventing it Sasha Levin
2013-01-25 11:20 ` [tip:perf/core] " tip-bot for Sasha Levin
2012-12-20 19:11 ` [PATCH] perf tools: remove redundant checks from _sort__sym_cmp Sasha Levin
2012-12-21 12:55 ` Namhyung Kim
2013-01-25 11:17 ` [tip:perf/core] " tip-bot for Sasha Levin
2012-12-20 19:11 ` [PATCH] virtio_console: correct error message on failure of debugfs_create_dir Sasha Levin
2012-12-21 7:59 ` Amit Shah
2012-12-24 11:55 ` Arnd Bergmann
2012-12-24 17:39 ` Greg Kroah-Hartman
2012-12-24 18:24 ` Sasha Levin
2012-12-24 18:43 ` Greg Kroah-Hartman
2012-12-20 19:11 ` [PATCH] debugfs: remove redundant initialization of dentry Sasha Levin
2012-12-20 19:11 ` [PATCH] PCI: cpqphp: minor cleanup and removal of unreachable paths Sasha Levin
2013-01-07 18:48 ` Bjorn Helgaas
2012-12-20 19:11 ` [PATCH] bnx2x: use ARRAY_SIZE where possible Sasha Levin
2012-12-23 8:49 ` Eilon Greenstein
2012-12-28 4:30 ` David Miller
2012-12-20 19:11 ` [PATCH] wireless: mwifiex: remove unreachable paths Sasha Levin
2012-12-20 20:13 ` Bing Zhao
2012-12-20 19:11 ` [PATCH] mmc: omap_hsmmc: correct precedence of operators Sasha Levin
2012-12-20 20:30 ` Felipe Balbi
2012-12-20 23:04 ` Paul Walmsley
2012-12-20 19:11 ` [PATCH] kdb: use ARRAY_SIZE where possible Sasha Levin
2012-12-20 19:11 ` [PATCH] rcutorture: don't compare ptr with 0 Sasha Levin
2012-12-20 22:39 ` Josh Triplett
2013-01-04 17:27 ` Paul E. McKenney
2012-12-20 19:11 ` [PATCH] sched: fair: simplify can_migrate_task a bit Sasha Levin
2012-12-20 19:11 ` [PATCH] uprobes: remove redundant check Sasha Levin
2013-01-25 11:21 ` [tip:perf/core] " tip-bot for Sasha Levin
2012-12-20 19:11 ` [PATCH] cgroup: " Sasha Levin
2012-12-20 19:18 ` Tejun Heo
2012-12-20 19:24 ` Sasha Levin [this message]
2012-12-20 19:11 ` [PATCH] mm: memory_hotplug: no need to check res twice in add_memory Sasha Levin
2012-12-20 19:11 ` [PATCH] x86, efi: correct precedence of operators in setup_efi_pci Sasha Levin
2012-12-20 19:59 ` [tip:x86/urgent] " tip-bot for Sasha Levin
2012-12-20 19:11 ` [PATCH] arch/x86/platform/uv: use ARRAY_SIZE where possible Sasha Levin
2012-12-20 22:37 ` [tip:x86/cleanups] " tip-bot for Sasha Levin
2012-12-20 19:11 ` [PATCH] um: don't compare a pointer to 0 Sasha Levin
2012-12-20 22:39 ` [tip:x86/cleanups] " tip-bot for Sasha Levin
2012-12-20 19:11 ` [PATCH] x86, apb_timer: remove unused variable percpu_timer Sasha Levin
2012-12-20 22:40 ` [tip:x86/cleanups] " tip-bot for Sasha Levin
2012-12-20 19:11 ` [PATCH] kdb: use DIV_ROUND_UP where possible Sasha Levin
2012-12-20 19:11 ` [PATCH] mm/sparse: don't check return value of alloc_bootmem calls Sasha Levin
2012-12-20 20:23 ` David Rientjes
2012-12-20 20:36 ` Sasha Levin
2012-12-20 20:43 ` David Rientjes
2012-12-20 19:11 ` [PATCH] slob: use DIV_ROUND_UP where possible Sasha Levin
2012-12-20 19:40 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D365F2.7070607@oracle.com \
--to=sasha.levin@oracle.com \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).