From: Laxman Dewangan <ldewangan@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "vinod.koul@intel.com" <vinod.koul@intel.com>,
"djbw@fb.com" <djbw@fb.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Stephen Warren <swarren@nvidia.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] dma: tegra: implement flags parameters for cyclic transfer
Date: Fri, 21 Dec 2012 09:53:43 +0530 [thread overview]
Message-ID: <50D3E44F.4060007@nvidia.com> (raw)
In-Reply-To: <50D340E1.7040600@wwwdotorg.org>
On Thursday 20 December 2012 10:16 PM, Stephen Warren wrote:
> On 12/19/2012 11:11 PM, Laxman Dewangan wrote:
>> On Wednesday 19 December 2012 10:32 PM, Stephen Warren wrote:
>>> On 12/19/2012 06:40 AM, Laxman Dewangan wrote:
>>>> The flag parameter is added in the cyclic transfer request.
>>>> Use the flag option of:
>>>> - DMA_PREP_INTERRUPT for enabling interrupt.
>>>> - DMA_CTRL_ACK for deciding whether ack is requred or not for
>>>> descriptor.
>>> Do the relevant drivers that use Tegra's DMA engine already set flags
>>> correctly, so that this change won't cause any regressions?
>>>
>> Currently, the sound soc driver uses the cyclic mode of dma transfer and
>> it has already enable the proper flags. This was done recently after
>> adding flags in cyclic api.
>> Also, there was bug in our dma driver for not setting DMA_CTRL_ACK by
>> default for cyclic case.
>> This will fix the issue.
> OK. I assume "This was done recently after adding flags in cyclic api."
> was a patch that went into 3.8? So, this patch is a bug-fix that should
> be included in 3.8 then?
I can see this in Linux 3.7 tag.
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=history;f=drivers/dma/tegra20-apb-dma.c;h=528c62dd4b00e1b52928ff66f3a54e7ae206680f;hb=29594404d7fe73cd80eaa4ee8c43dcc53970c60e
next prev parent reply other threads:[~2012-12-21 4:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 13:40 [PATCH] dma: tegra: implement flags parameters for cyclic transfer Laxman Dewangan
2012-12-19 17:02 ` Stephen Warren
2012-12-20 6:11 ` Laxman Dewangan
2012-12-20 16:46 ` Stephen Warren
2012-12-21 4:23 ` Laxman Dewangan [this message]
2012-12-21 20:53 ` Stephen Warren
2013-01-07 13:52 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D3E44F.4060007@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=djbw@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox