public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roland Stigge <stigge@antcom.de>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: gregkh@linuxfoundation.org, Matthew Garrett <mjg@redhat.com>,
	"platform-driver-x86@vger.kernel.org" 
	<platform-driver-x86@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] samsung-laptop: Set keyboard backlight initially
Date: Mon, 24 Dec 2012 13:55:30 +0100	[thread overview]
Message-ID: <50D850C2.7050809@antcom.de> (raw)
In-Reply-To: <CAHR064iQeQrQF0qrGXJoCmYny2H_H_JnV_h8OvRSmD=bGE5eYA@mail.gmail.com>

On 24/12/12 09:41, Corentin Chary wrote:
> On Sun, Dec 23, 2012 at 6:21 PM, Roland Stigge <stigge@antcom.de> wrote:
>> After boot, /sys/devices/platform/samsung/leds/samsung::kbd_backlight/brightness
>> shows the maximum value (8) by readout, but the led is off. I need to manually
>> set it to the respective value to have keyboard backlight.
> 
> If the led is set to 0, what's the value after reboot ? 0 or 8 ?

Right - when writing 0 there before restart, the led value is actually 8
after reboot, and the LED hardware is ON. This holds for both reboot and
halt+poweron cycle.

Maybe this is related to the "#define MAX_BRIGHT 0x07" (which is unused
in samsung-laptop.c)? A bit confusing in the code - but your question
hints for some other bug (to be solved differently). Tell me if I can
help somehow, here.

> What's the behavior on windows ?

There is no windows available on this machine.

Thanks,

Roland

  reply	other threads:[~2012-12-24 12:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-23 17:21 [PATCH] samsung-laptop: Set keyboard backlight initially Roland Stigge
2012-12-24  8:41 ` Corentin Chary
2012-12-24 12:55   ` Roland Stigge [this message]
2013-01-03 20:46     ` Corentin Chary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50D850C2.7050809@antcom.de \
    --to=stigge@antcom.de \
    --cc=corentin.chary@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox