From: Laxman Dewangan <ldewangan@nvidia.com>
To: Marc Dietrich <marvin24@gmx.de>
Cc: "akpm@linuxfoundation.org" <akpm@linuxfoundation.org>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"rtc-linux@googlegroups.com" <rtc-linux@googlegroups.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH V2] rtc: add RTC driver for TPS6586x
Date: Thu, 27 Dec 2012 22:29:54 +0530 [thread overview]
Message-ID: <50DC7E8A.8000605@nvidia.com> (raw)
In-Reply-To: <2152592.FqkQ6Iyssd@ax5200p>
On Thursday 27 December 2012 09:26 PM, Marc Dietrich wrote:
> On Thursday 27 December 2012 20:29:14 Laxman Dewangan wrote:
>> On Thursday 27 December 2012 08:26 PM, Marc Dietrich wrote:
>>> Hi Laxman,
>>>
>>> On Friday 21 December 2012 20:42:28 you wrote:
>>>> +
>>>> + /* Set epoch start as 00:00:00:01:01:2000 */
>>>> + rtc->epoch_start = mktime(2000, 1, 1, 0, 0, 0);
>>> any reason why you hard coded it to 2000? All boards I know use 2009, so
>>> with this patch, everyone needs to set his clock again.
>> No specific reason. If 2009 should be default then I can push patch to
>> set it as 2009.
> At least myself would appreciate this.
>
> Stephen said on IRC, that this could be configurable via a property node from
> device tree (and also the IRQ which now comes from platform_data). Maybe this
> can be added later on. I really like to see this driver in mainline now.
I have not added platform data for setting epoch start time. I think we
should be fine to hardcode in probe itself.
The irq support is there as the mfd driver put proper alarm irq for rtc
when it adds mfd sub devices. The ultimate irq number allocated run time
through ird domain.
I tested with RTC test wwhich is part of Documentation/rtc.txt.
next prev parent reply other threads:[~2012-12-27 16:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-21 15:12 [PATCH V2] rtc: add RTC driver for TPS6586x Laxman Dewangan
2012-12-27 14:56 ` Marc Dietrich
2012-12-27 14:59 ` Laxman Dewangan
2012-12-27 15:56 ` Marc Dietrich
2012-12-27 16:59 ` Laxman Dewangan [this message]
2013-01-02 23:50 ` Andrew Morton
2013-01-03 6:16 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50DC7E8A.8000605@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=rtc-linux@googlegroups.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox