From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752960Ab2L0Sy2 (ORCPT ); Thu, 27 Dec 2012 13:54:28 -0500 Received: from terminus.zytor.com ([198.137.202.10]:57881 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752770Ab2L0Sy1 (ORCPT ); Thu, 27 Dec 2012 13:54:27 -0500 Message-ID: <50DC9935.6000201@zytor.com> Date: Thu, 27 Dec 2012 10:53:41 -0800 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Daniel Kiper CC: andrew.cooper3@citrix.com, ebiederm@xmission.com, jbeulich@suse.com, konrad.wilk@oracle.com, maxim.uvarov@oracle.com, mingo@redhat.com, tglx@linutronix.de, vgoyal@redhat.com, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xensource.com Subject: Re: [PATCH v3 09/11] x86/xen/enlighten: Add init and crash kexec/kdump hooks References: <1356574740-6806-1-git-send-email-daniel.kiper@oracle.com> <1356574740-6806-2-git-send-email-daniel.kiper@oracle.com> <1356574740-6806-3-git-send-email-daniel.kiper@oracle.com> <1356574740-6806-4-git-send-email-daniel.kiper@oracle.com> <1356574740-6806-5-git-send-email-daniel.kiper@oracle.com> <1356574740-6806-6-git-send-email-daniel.kiper@oracle.com> <1356574740-6806-7-git-send-email-daniel.kiper@oracle.com> <1356574740-6806-8-git-send-email-daniel.kiper@oracle.com> <1356574740-6806-9-git-send-email-daniel.kiper@oracle.com> <1356574740-6806-10-git-send-email-daniel.kiper@oracle.com> In-Reply-To: <1356574740-6806-10-git-send-email-daniel.kiper@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/26/2012 06:18 PM, Daniel Kiper wrote: > Add init and crash kexec/kdump hooks. > > Signed-off-by: Daniel Kiper > --- > arch/x86/xen/enlighten.c | 11 +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) On the general issue of hooks: Hooks need their pre- and postsemantics extremely ewell documented, let they end up being an impossible roadblock to development. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.