From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752419Ab3ABHkT (ORCPT <rfc822;w@1wt.eu>);
	Wed, 2 Jan 2013 02:40:19 -0500
Received: from mail-pa0-f41.google.com ([209.85.220.41]:44038 "EHLO
	mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751229Ab3ABHkR (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 2 Jan 2013 02:40:17 -0500
Message-ID: <50E3E45A.5050003@gmail.com>
Date: Wed, 02 Jan 2013 15:40:10 +0800
From: Mark Zhang <nvmarkzhang@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: Terje Bergstrom <tbergstrom@nvidia.com>
CC: thierry.reding@avionic-design.de, airlied@linux.ie, dev@lynxeye.de,
        dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCHv4 3/8] gpu: host1x: Add channel support
References: <1356089964-5265-1-git-send-email-tbergstrom@nvidia.com> <1356089964-5265-4-git-send-email-tbergstrom@nvidia.com>
In-Reply-To: <1356089964-5265-4-git-send-email-tbergstrom@nvidia.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Just one minor issue. Check below.

On 12/21/2012 07:39 PM, Terje Bergstrom wrote:
> Add support for host1x client modules, and host1x channels to submit
> work to the clients. The work is submitted in GEM CMA buffers, so
> this patch adds support for them.
> 
> Signed-off-by: Terje Bergstrom <tbergstrom@nvidia.com>
> ---
[...]
> +/*
> + * Begin a cdma submit
> + */
> +int host1x_cdma_begin(struct host1x_cdma *cdma, struct host1x_job *job)
> +{
> +	struct host1x *host1x = cdma_to_host1x(cdma);
> +
> +	mutex_lock(&cdma->lock);
> +
> +	if (job->timeout) {
> +		/* init state on first submit with timeout value */
> +		if (!cdma->timeout.initialized) {
> +			int err;
> +			err = host1x->cdma_op.timeout_init(cdma,
> +					job->syncpt_id);
> +			if (err) {
> +				mutex_unlock(&cdma->lock);
> +				return err;
> +			}
> +		}
> +	}
> +	if (!cdma->running)
> +		host1x->cdma_op.start(cdma);
> +
> +	cdma->slots_free = 0;
> +	cdma->slots_used = 0;
> +	cdma->first_get = host1x->cdma_pb_op.putptr(&cdma->push_buffer);
> +
> +	trace_host1x_cdma_begin(job->ch->dev->name);

Seems missing "mutex_unlock(&cdma->lock);" here.

> +	return 0;
> +}
[...]
> +
>  #endif /*  _TRACE_HOST1X_H */
>  
>  /* This part must be outside protection */
>