From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753215Ab3ACGVU (ORCPT ); Thu, 3 Jan 2013 01:21:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59133 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751625Ab3ACGVT (ORCPT ); Thu, 3 Jan 2013 01:21:19 -0500 Message-ID: <50E5234F.8040707@redhat.com> Date: Thu, 03 Jan 2013 01:21:03 -0500 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Michel Lespinasse CC: Andy Lutomirski , Ingo Molnar , Al Viro , Hugh Dickins , Jorn_Engel , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/9] mm: make do_mmap_pgoff return populate as a size in bytes, not as a bool References: <1356050997-2688-1-git-send-email-walken@google.com> <20121222094545.GA4222@google.com> In-Reply-To: <20121222094545.GA4222@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/22/2012 04:45 AM, Michel Lespinasse wrote: > do_mmap_pgoff() rounds up the desired size to the next PAGE_SIZE multiple, > however there was no equivalent code in mm_populate(), which caused issues. > > This could be fixed by introduced the same rounding in mm_populate(), > however I think it's preferable to make do_mmap_pgoff() return populate > as a size rather than as a boolean, so we don't have to duplicate the > size rounding logic in mm_populate(). > > Signed-off-by: Michel Lespinasse Acked-by: Rik van Riel -- All rights reversed