* [PATCH] arm/davinci/musb: fix mispint introduced by commit 032ec49f5351e9cb242b1a1c367d14415043ab95
@ 2012-12-20 21:59 Mikhail Kshevetskiy
2012-12-21 9:06 ` Felipe Balbi
0 siblings, 1 reply; 4+ messages in thread
From: Mikhail Kshevetskiy @ 2012-12-20 21:59 UTC (permalink / raw)
To: linux-kernel, Felipe Balbi, Greg Kroah-Hartman, linux-usb
Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@gmail.com>
---
drivers/usb/musb/da8xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c
index 8bc44b7..0ed24a6 100644
--- a/drivers/usb/musb/da8xx.c
+++ b/drivers/usb/musb/da8xx.c
@@ -327,7 +327,7 @@ static irqreturn_t da8xx_musb_interrupt(int irq, void *hci)
u8 devctl = musb_readb(mregs, MUSB_DEVCTL);
int err;
- err = musb->int_usb & USB_INTR_VBUSERROR;
+ err = musb->int_usb & MUSB_INTR_VBUSERROR;
if (err) {
/*
* The Mentor core doesn't debounce VBUS as needed
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm/davinci/musb: fix mispint introduced by commit 032ec49f5351e9cb242b1a1c367d14415043ab95
2012-12-20 21:59 [PATCH] arm/davinci/musb: fix mispint introduced by commit 032ec49f5351e9cb242b1a1c367d14415043ab95 Mikhail Kshevetskiy
@ 2012-12-21 9:06 ` Felipe Balbi
2012-12-22 17:52 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Felipe Balbi @ 2012-12-21 9:06 UTC (permalink / raw)
To: Mikhail Kshevetskiy
Cc: linux-kernel, Felipe Balbi, Greg Kroah-Hartman, linux-usb
[-- Attachment #1: Type: text/plain, Size: 835 bytes --]
On Fri, Dec 21, 2012 at 01:59:06AM +0400, Mikhail Kshevetskiy wrote:
please respin this patch with a real commit log.
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@gmail.com>
> ---
> drivers/usb/musb/da8xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c
> index 8bc44b7..0ed24a6 100644
> --- a/drivers/usb/musb/da8xx.c
> +++ b/drivers/usb/musb/da8xx.c
> @@ -327,7 +327,7 @@ static irqreturn_t da8xx_musb_interrupt(int irq, void *hci)
> u8 devctl = musb_readb(mregs, MUSB_DEVCTL);
> int err;
>
> - err = musb->int_usb & USB_INTR_VBUSERROR;
> + err = musb->int_usb & MUSB_INTR_VBUSERROR;
> if (err) {
> /*
> * The Mentor core doesn't debounce VBUS as needed
> --
> 1.7.10.4
>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm/davinci/musb: fix mispint introduced by commit 032ec49f5351e9cb242b1a1c367d14415043ab95
2012-12-21 9:06 ` Felipe Balbi
@ 2012-12-22 17:52 ` Sergei Shtylyov
2013-01-05 18:50 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2012-12-22 17:52 UTC (permalink / raw)
To: Mikhail Kshevetskiy; +Cc: balbi, linux-kernel, Greg Kroah-Hartman, linux-usb
Hello.
On 21-12-2012 13:06, Felipe Balbi wrote:
> please respin this patch with a real commit log.
And then, when referring to commit ID that broke da8xx.c don't forget to
also specify the commit summmary in parens (or however you like).
>> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@gmail.com>
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm/davinci/musb: fix mispint introduced by commit 032ec49f5351e9cb242b1a1c367d14415043ab95
2012-12-22 17:52 ` Sergei Shtylyov
@ 2013-01-05 18:50 ` Sergei Shtylyov
0 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2013-01-05 18:50 UTC (permalink / raw)
To: Mikhail Kshevetskiy; +Cc: balbi, linux-kernel, Greg Kroah-Hartman, linux-usb
On 12/22/2012 08:52 PM, Sergei Shtylyov wrote:
>> please respin this patch with a real commit log.
> And then, when referring to commit ID that broke da8xx.c don't forget to also
> specify the commit summmary in parens (or however you like).
Also, please s/davinci/da8xx/ in the subject. OMAP-L1x/DA8xx is not exactly
DaVinci.
>>> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@gmail.com>
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-05 17:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-20 21:59 [PATCH] arm/davinci/musb: fix mispint introduced by commit 032ec49f5351e9cb242b1a1c367d14415043ab95 Mikhail Kshevetskiy
2012-12-21 9:06 ` Felipe Balbi
2012-12-22 17:52 ` Sergei Shtylyov
2013-01-05 18:50 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox