From: Rob Herring <robherring2@gmail.com>
To: Denis Efremov <yefremov.denis@gmail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Mike Turquette <mturquette@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: remove exported function from __init section
Date: Sun, 06 Jan 2013 08:58:40 -0600 [thread overview]
Message-ID: <50E99120.7080608@gmail.com> (raw)
In-Reply-To: <1357482103-14116-1-git-send-email-yefremov.denis@gmail.com>
On 01/06/2013 08:21 AM, Denis Efremov wrote:
> The symbol of_fixed_clk_setup is exported and annotated __init.
> This looks like section mismatch.
> Fix this by removing the __init annotation of of_fixed_clk_setup.
>
> Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
Mike should take this.
Acked-by: Rob Herring <rob.herring@calxeda.com>
> ---
> drivers/clk/clk-fixed-rate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk-fixed-rate.c b/drivers/clk/clk-fixed-rate.c
> index af78ed6..a53b53b 100644
> --- a/drivers/clk/clk-fixed-rate.c
> +++ b/drivers/clk/clk-fixed-rate.c
> @@ -85,7 +85,7 @@ struct clk *clk_register_fixed_rate(struct device *dev, const char *name,
> /**
> * of_fixed_clk_setup() - Setup function for simple fixed rate clock
> */
> -void __init of_fixed_clk_setup(struct device_node *node)
> +void of_fixed_clk_setup(struct device_node *node)
> {
> struct clk *clk;
> const char *clk_name = node->name;
>
next prev parent reply other threads:[~2013-01-06 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-06 14:21 [PATCH] clk: remove exported function from __init section Denis Efremov
2013-01-06 14:58 ` Rob Herring [this message]
2013-01-14 23:34 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E99120.7080608@gmail.com \
--to=robherring2@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=yefremov.denis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox