Re: [PATCH 2/2] cgroups: fix cgroup_event_listener error handling

Li Zefan
2013-01-08T06:29:11Z

> cgroups: fix cgroup_event_listener error handling
>
> The error handling in cgroup_event_listener.c did not correctly deal
> with either an error opening either <control_file> or
> cgroup.event_control. Due to an uninitialized variable the program
> exit code was undefined if either of these opens failed.
>
> This patch simplifies and corrects cgroup_event_listener.c error
> handling by:
> 1. using err*() rather than printf(),exit()
> 2. depending on process exit to close open files
>
> With this patch failures always return non-zero error.
>
> Signed-off-by: Greg Thelen <gthelen@google.com>

Acked-by: Li Zefan <lizefan@huawei.com>

> ---
> tools/cgroup/cgroup_event_listener.c | 72 ++++++++++-----------------------
> 1 files changed, 22 insertions(+), 50 deletions(-)