* [PATCH] drivers: xhci: fix incorrect bit test
@ 2013-01-08 3:39 Nickolai Zeldovich
2013-01-08 12:35 ` Sergei Shtylyov
2013-01-17 0:38 ` Sarah Sharp
0 siblings, 2 replies; 3+ messages in thread
From: Nickolai Zeldovich @ 2013-01-08 3:39 UTC (permalink / raw)
To: Sarah Sharp; +Cc: Nickolai Zeldovich, linux-usb, linux-kernel
Fix incorrect bit test that originally showed up in
4ee823b83bc9851743fab756c76b27d6a1e2472b: use '&' instead of '&&'.
Signed-off-by: Nickolai Zeldovich <nickolai@csail.mit.edu>
---
drivers/usb/host/xhci-ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index cbb44b7..06921b6 100644
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xhci-ring.c
@@ -1698,7 +1698,7 @@ static void handle_port_status(struct xhci_hcd *xhci,
faked_port_index + 1);
if (slot_id && xhci->devs[slot_id])
xhci_ring_device(xhci, slot_id);
- if (bus_state->port_remote_wakeup && (1 << faked_port_index)) {
+ if (bus_state->port_remote_wakeup & (1 << faked_port_index)) {
bus_state->port_remote_wakeup &=
~(1 << faked_port_index);
xhci_test_and_clear_bit(xhci, port_array,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drivers: xhci: fix incorrect bit test
2013-01-08 3:39 [PATCH] drivers: xhci: fix incorrect bit test Nickolai Zeldovich
@ 2013-01-08 12:35 ` Sergei Shtylyov
2013-01-17 0:38 ` Sarah Sharp
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2013-01-08 12:35 UTC (permalink / raw)
To: Nickolai Zeldovich; +Cc: Sarah Sharp, linux-usb, linux-kernel
Hello.
On 08-01-2013 7:39, Nickolai Zeldovich wrote:
> Fix incorrect bit test that originally showed up in
> 4ee823b83bc9851743fab756c76b27d6a1e2472b: use '&' instead of '&&'.
Please also specify the summary of that commit in parens (or however you
like).
> Signed-off-by: Nickolai Zeldovich <nickolai@csail.mit.edu>
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drivers: xhci: fix incorrect bit test
2013-01-08 3:39 [PATCH] drivers: xhci: fix incorrect bit test Nickolai Zeldovich
2013-01-08 12:35 ` Sergei Shtylyov
@ 2013-01-17 0:38 ` Sarah Sharp
1 sibling, 0 replies; 3+ messages in thread
From: Sarah Sharp @ 2013-01-17 0:38 UTC (permalink / raw)
To: Nickolai Zeldovich; +Cc: linux-usb, linux-kernel
Hi Nickolai,
Thanks for catching this. Don't worry about sending a new patch with
the short description for the commit, I'll fix that when I send it off.
Sarah Sharp
On Mon, Jan 07, 2013 at 10:39:31PM -0500, Nickolai Zeldovich wrote:
> Fix incorrect bit test that originally showed up in
> 4ee823b83bc9851743fab756c76b27d6a1e2472b: use '&' instead of '&&'.
>
> Signed-off-by: Nickolai Zeldovich <nickolai@csail.mit.edu>
> ---
> drivers/usb/host/xhci-ring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index cbb44b7..06921b6 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -1698,7 +1698,7 @@ static void handle_port_status(struct xhci_hcd *xhci,
> faked_port_index + 1);
> if (slot_id && xhci->devs[slot_id])
> xhci_ring_device(xhci, slot_id);
> - if (bus_state->port_remote_wakeup && (1 << faked_port_index)) {
> + if (bus_state->port_remote_wakeup & (1 << faked_port_index)) {
> bus_state->port_remote_wakeup &=
> ~(1 << faked_port_index);
> xhci_test_and_clear_bit(xhci, port_array,
> --
> 1.7.10.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-17 0:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-08 3:39 [PATCH] drivers: xhci: fix incorrect bit test Nickolai Zeldovich
2013-01-08 12:35 ` Sergei Shtylyov
2013-01-17 0:38 ` Sarah Sharp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox