From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757811Ab3AIJjK (ORCPT ); Wed, 9 Jan 2013 04:39:10 -0500 Received: from relay.parallels.com ([195.214.232.42]:47766 "EHLO relay.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757582Ab3AIJjH (ORCPT ); Wed, 9 Jan 2013 04:39:07 -0500 Message-ID: <50ED3AB8.90006@parallels.com> Date: Wed, 9 Jan 2013 13:39:04 +0400 From: Stanislav Kinsbursky User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: CC: , , , Subject: Re: [PATCH] nfsd: fix unused "nn" variable warning in free_client() References: <20130109093834.13789.270.stgit@localhost.localdomain> In-Reply-To: <20130109093834.13789.270.stgit@localhost.localdomain> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.30.18.163] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bruce, sorry, forgot to add: Reported-by: Toralf Förster 09.01.2013 13:38, Stanislav Kinsbursky пишет: > If CONFIG_LOCKDEP is disabled, then there would be a warning like this: > > CC [M] fs/nfsd/nfs4state.o > fs/nfsd/nfs4state.c: In function ‘free_client’: > fs/nfsd/nfs4state.c:1051:19: warning: unused variable ‘nn’ [-Wunused-variable] > > So, let's add "maybe_unused" tag to this variable. > > Signed-off-by: Stanislav Kinsbursky > --- > fs/nfsd/nfs4state.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c > index 8f7362c..739a6c2 100644 > --- a/fs/nfsd/nfs4state.c > +++ b/fs/nfsd/nfs4state.c > @@ -1048,7 +1048,7 @@ static struct nfs4_client *alloc_client(struct xdr_netobj name) > static inline void > free_client(struct nfs4_client *clp) > { > - struct nfsd_net *nn = net_generic(clp->net, nfsd_net_id); > + struct nfsd_net __maybe_unused *nn = net_generic(clp->net, nfsd_net_id); > > lockdep_assert_held(&nn->client_lock); > while (!list_empty(&clp->cl_sessions)) { > -- Best regards, Stanislav Kinsbursky