Re: [PATCH] Smack: prevent revoke-subject from failing when unseen label is written to it

Casey Schaufler
2012-11-27T17:29:37Z

On 11/27/2012 7:28 AM, Rafal Krypa wrote:
> Special file /smack/revoke-subject will silently accept labels that are not
> present on the subject label list. Nothing has to be done for such labels,
> as there are no rules for them to revoke.
>
> Targeted for git://git.gitorious.org/smack-next/kernel.git

I will queue this for 3.9 as I've just submitted the 3.8 Smack
changes.

>
> Signed-off-by: Rafal Krypa <r.krypa@samsung.com>
> ---
> security/smack/smackfs.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
> index 76a5dca..337e32c 100644
> --- a/security/smack/smackfs.c
> +++ b/security/smack/smackfs.c
> @@ -2035,10 +2035,8 @@ static ssize_t smk_write_revoke_subj(struct file *file, const char __user *buf,
> }
>
> skp = smk_find_entry(cp);
> - if (skp == NULL) {
> - rc = -EINVAL;
> + if (skp == NULL)
> goto free_out;
> - }
>
> rule_list = &skp->smk_rules;
> rule_lock = &skp->smk_rules_lock;