Re: [PATCH v5 6/5] KVM: x86: clear write_fault_to_shadow_pgtable explicitly

Marcelo Tosatti
2013-01-11T19:55:31Z

On Fri, Jan 11, 2013 at 10:12:58PM +0800, Xiao Guangrong wrote:
> On 01/11/2013 09:15 PM, Marcelo Tosatti wrote:
>
> >
> > This is cryptic. Its not obvious at all for someone modifying the code,
> > for example.
> >
> > Can you please clear it explicitly?
>
> Sure, this is the patch to apply your idea, is it good to you? :)
>
> ============================================
> Subject: [PATCH 6/6] KVM: x86: clear write_fault_to_shadow_pgtable explicitly
>
> Clear it explicitly when exiting x86_emulate_instruction to clarify the code,
> it is suggested by Marcelo
>
> Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
> ---
> arch/x86/kvm/x86.c | 16 ++++++++++++----
> 1 files changed, 12 insertions(+), 4 deletions(-)

Fine, please rebase against queue.