Re: [PATCH 07/14] usb: ehci-omap: Instantiate PHY devices if required

Roger Quadros
2013-01-11T11:06:54Z

On 01/11/2013 12:59 PM, Roger Quadros wrote:
> On 01/10/2013 10:48 PM, Alan Stern wrote:
>> On Thu, 10 Jan 2013, Roger Quadros wrote:
>>
>>> If the OMAP's Host controller is in PHY mode then we instantiate
>>> a platform device for the PHY (one for each port in PHY mode) and
>>> hold a reference to it so that we can use the usb_phy API, e.g.
>>> while suspend/resume.
>>>
>>> The platform data for the PHY must be supplied in the newly added
>>> .phy_config parameter in struct usbhs_omap_platform_data.
>>>
>>> The end goal is to move the PHY's reset and power handling code
>>> out of the ehci-omap driver and into the phy driver.
>>
>> As mentioned in another thread, I would prefer to have these changes to
>> ehci-omap.c made after the driver is converted to the new "ehci-hcd is
>> a library" scheme. The patch below does the conversion; it is meant to
>> apply on top of the similar patch for ehci-mxc posted recently on the
>> linux-usb mailing list.
>>
>> After this conversion, the omap_ehci_hcd private data structure doesn't
>> have to be allocated specifically. It can be handled in the same way
>> as the private data structure in the ehci-mxc patch.
>>
>> I haven't even tried to compile this. Please let me know how it works.
>>
>
> Alan,
>
> Thanks for the patch. I've pasted the version that builds and works and
> put you as the Author of the patch, hope it is fine.
>
> I could not find the equivalent ehci-mxc implementation though. Any
> pointers to that? Thanks.

OK I found it. Previously I was searching in the archives :P.

cheers,
-roger