Re: [PATCH 04/14] usb: phy: nop: Handle power supply regulator for the PHY

Russell King - ARM Linux
2013-01-14T12:18:30Z

On Mon, Jan 14, 2013 at 01:51:07PM +0200, Roger Quadros wrote:
> On 01/14/2013 01:25 PM, Russell King - ARM Linux wrote:
> > Also consider... is dev_err() appropriate for an "error", for which you
> > print a message and continue as if nothing went wrong. To me that sounds
> > more like a warning than an error, so maybe dev_warn() would be more
> > appropriate?
> >
> I used dev_dbg(), because we don't treat not getting the power supply
> regulator as that serious.

This comment is about what you do when regulator_enable() and the like
returns non-zero.