Re: [PATCH 1/2] tuntap: forbid calling TUNSETIFF when detached

Stefan Hajnoczi
2013-01-11T14:42:41Z

On Fri, Jan 11, 2013 at 04:50:41PM +0800, Jason Wang wrote:
> @@ -1546,6 +1544,9 @@ static int tun_set_iff(struct net *net, struct file *file, struct ifreq *ifr)
> struct net_device *dev;
> int err;
>
> + if (rcu_dereference_protected(tfile->detached, lockdep_rtnl_is_held()))
> + return -EINVAL;
> +

How come none of the other tfile->detached users call rcu_*()?

Stefan