* [PATCH 1/2] tty: cleanup the panic message
@ 2013-01-12 4:01 Cong Ding
2013-01-12 4:01 ` [PATCH 2/2] tty: cleanup checkpatch warning in pty.c Cong Ding
2013-01-12 9:10 ` [PATCH 1/2] tty: cleanup the panic message Jiri Slaby
0 siblings, 2 replies; 3+ messages in thread
From: Cong Ding @ 2013-01-12 4:01 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, linux-kernel; +Cc: Cong Ding
the "\n" in panic message is excess, so we remove it in tty/pty.c as what it
is used in other places.
Signed-off-by: Cong Ding <dinggnu@gmail.com>
---
drivers/tty/pty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/pty.c b/drivers/tty/pty.c
index be6a373..64fcbdb 100644
--- a/drivers/tty/pty.c
+++ b/drivers/tty/pty.c
@@ -795,7 +795,7 @@ static void __init unix98_pty_init(void)
cdev_init(&ptmx_cdev, &ptmx_fops);
if (cdev_add(&ptmx_cdev, MKDEV(TTYAUX_MAJOR, 2), 1) ||
register_chrdev_region(MKDEV(TTYAUX_MAJOR, 2), 1, "/dev/ptmx") < 0)
- panic("Couldn't register /dev/ptmx driver\n");
+ panic("Couldn't register /dev/ptmx driver");
device_create(tty_class, NULL, MKDEV(TTYAUX_MAJOR, 2), NULL, "ptmx");
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 2/2] tty: cleanup checkpatch warning in pty.c
2013-01-12 4:01 [PATCH 1/2] tty: cleanup the panic message Cong Ding
@ 2013-01-12 4:01 ` Cong Ding
2013-01-12 9:10 ` [PATCH 1/2] tty: cleanup the panic message Jiri Slaby
1 sibling, 0 replies; 3+ messages in thread
From: Cong Ding @ 2013-01-12 4:01 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, linux-kernel; +Cc: Cong Ding
spaces are used for indent in 3 places of tty/pty.c, we change it to tab.
Signed-off-by: Cong Ding <dinggnu@gmail.com>
---
drivers/tty/pty.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/pty.c b/drivers/tty/pty.c
index 64fcbdb..358a5fe 100644
--- a/drivers/tty/pty.c
+++ b/drivers/tty/pty.c
@@ -55,9 +55,9 @@ static void pty_close(struct tty_struct *tty, struct file *filp)
set_bit(TTY_OTHER_CLOSED, &tty->flags);
#ifdef CONFIG_UNIX98_PTYS
if (tty->driver == ptm_driver) {
- mutex_lock(&devpts_mutex);
+ mutex_lock(&devpts_mutex);
devpts_pty_kill(tty->link->driver_data);
- mutex_unlock(&devpts_mutex);
+ mutex_unlock(&devpts_mutex);
}
#endif
tty_unlock(tty);
@@ -661,7 +661,7 @@ static const struct tty_operations pty_unix98_ops = {
* Allocate a unix98 pty master device from the ptmx driver.
*
* Locking: tty_mutex protects the init_dev work. tty->count should
- * protect the rest.
+ * protect the rest.
* allocated_ptys_lock handles the list of free pty numbers
*/
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] tty: cleanup the panic message
2013-01-12 4:01 [PATCH 1/2] tty: cleanup the panic message Cong Ding
2013-01-12 4:01 ` [PATCH 2/2] tty: cleanup checkpatch warning in pty.c Cong Ding
@ 2013-01-12 9:10 ` Jiri Slaby
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Slaby @ 2013-01-12 9:10 UTC (permalink / raw)
To: Cong Ding; +Cc: Greg Kroah-Hartman, linux-kernel
On 01/12/2013 05:01 AM, Cong Ding wrote:
> the "\n" in panic message is excess, so we remove it in tty/pty.c as what it
> is used in other places.
All three are OK. Thanks.
--
js
suse labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-12 9:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-12 4:01 [PATCH 1/2] tty: cleanup the panic message Cong Ding
2013-01-12 4:01 ` [PATCH 2/2] tty: cleanup checkpatch warning in pty.c Cong Ding
2013-01-12 9:10 ` [PATCH 1/2] tty: cleanup the panic message Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox