* [char-misc-next V2] mei: drop the warning when cl is not initialized during unlinking
@ 2013-01-10 15:32 Tomas Winkler
2013-01-14 14:14 ` Sedat Dilek
0 siblings, 1 reply; 7+ messages in thread
From: Tomas Winkler @ 2013-01-10 15:32 UTC (permalink / raw)
To: gregkh; +Cc: arnd, alan, linux-kernel, sedat.dilek, Tomas Winkler
On systems where wd and amthif is not initialized
we will hit cl->dev == NULL. This condition is okay
so we don't need to be laud about it.
Fixes the follwing warning during suspend
[ 137.061985] WARNING: at drivers/misc/mei/client.c:315 mei_cl_unlink+0x86/0x90 [mei]()
[ 137.061986] Hardware name: 530U3BI/530U4BI/530U4BH
[ 137.062140] Modules linked in: snd_hda_codec_hdmi snd_hda_codec_realtek joydev coretemp kvm_intel snd_hda_intel snd_hda_codec kvm arc4 iwldvm snd_hwdep i915 snd_pcm mac80211 ghash_clmulni_intel snd_page_alloc aesni_intel snd_seq_midi xts snd_seq_midi_event aes_x86_64 rfcomm snd_rawmidi parport_pc bnep lrw snd_seq uvcvideo i2c_algo_bit ppdev gf128mul iwlwifi snd_timer drm_kms_helper ablk_helper cryptd drm snd_seq_device videobuf2_vmalloc psmouse videobuf2_memops snd cfg80211 btusb videobuf2_core soundcore videodev lp bluetooth samsung_laptop wmi microcode mei serio_raw mac_hid video hid_generic lpc_ich parport usbhid hid r8169
[ 137.062143] Pid: 2706, comm: kworker/u:15 Tainted: G D W 3.8.0-rc2-next20130109-1-iniza-generic #1
[ 137.062144] Call Trace:
[ 137.062156] [<ffffffff8105860f>] warn_slowpath_common+0x7f/0xc0
[ 137.062159] [<ffffffff8135b1ea>] ? ioread32+0x3a/0x40
[ 137.062162] [<ffffffff8105866a>] warn_slowpath_null+0x1a/0x20
[ 137.062168] [<ffffffffa0076be6>] mei_cl_unlink+0x86/0x90 [mei]
[ 137.062173] [<ffffffffa0071325>] mei_reset+0xc5/0x240 [mei]
[ 137.062178] [<ffffffffa0073703>] mei_pci_resume+0xa3/0x110 [mei]
[ 137.062183] [<ffffffff81379cae>] pci_pm_resume+0x7e/0xe0
[ 137.062185] [<ffffffff81379c30>] ? pci_pm_thaw+0x80/0x80
[ 137.062189] [<ffffffff8145a415>] dpm_run_callback.isra.6+0x25/0x50
[ 137.062192] [<ffffffff8145a6cf>] device_resume+0x9f/0x140
[ 137.062194] [<ffffffff8145a791>] async_resume+0x21/0x50
[ 137.062200] [<ffffffff810858b0>] async_run_entry_fn+0x90/0x1c0
[ 137.062203] [<ffffffff810778e5>] process_one_work+0x155/0x460
[ 137.062207] [<ffffffff81078578>] worker_thread+0x168/0x400
[ 137.062210] [<ffffffff81078410>] ? manage_workers+0x2b0/0x2b0
[ 137.062214] [<ffffffff8107d9f0>] kthread+0xc0/0xd0
[ 137.062218] [<ffffffff8107d930>] ? flush_kthread_worker+0xb0/0xb0
[ 137.062222] [<ffffffff816bac6c>] ret_from_fork+0x7c/0xb0
[ 137.062228] [<ffffffff8107d930>] ? flush_kthread_worker+0xb0/0xb0
Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
V2: fix a typo in the comment
drivers/misc/mei/client.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c
index d566dd8..a921001 100644
--- a/drivers/misc/mei/client.c
+++ b/drivers/misc/mei/client.c
@@ -312,8 +312,9 @@ int mei_cl_unlink(struct mei_cl *cl)
if (!cl)
return 0;
- if (WARN_ON(!cl->dev))
- return -EINVAL;
+ /* wd and amthif might not be initialized */
+ if (!cl->dev)
+ return 0;
dev = cl->dev;
--
1.7.4.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [char-misc-next V2] mei: drop the warning when cl is not initialized during unlinking
2013-01-10 15:32 [char-misc-next V2] mei: drop the warning when cl is not initialized during unlinking Tomas Winkler
@ 2013-01-14 14:14 ` Sedat Dilek
2013-01-14 14:32 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Sedat Dilek @ 2013-01-14 14:14 UTC (permalink / raw)
To: Tomas Winkler; +Cc: gregkh, arnd, alan, linux-kernel
On Thu, Jan 10, 2013 at 4:32 PM, Tomas Winkler <tomas.winkler@intel.com> wrote:
> On systems where wd and amthif is not initialized
> we will hit cl->dev == NULL. This condition is okay
> so we don't need to be laud about it.
>
> Fixes the follwing warning during suspend
> [ 137.061985] WARNING: at drivers/misc/mei/client.c:315 mei_cl_unlink+0x86/0x90 [mei]()
> [ 137.061986] Hardware name: 530U3BI/530U4BI/530U4BH
> [ 137.062140] Modules linked in: snd_hda_codec_hdmi snd_hda_codec_realtek joydev coretemp kvm_intel snd_hda_intel snd_hda_codec kvm arc4 iwldvm snd_hwdep i915 snd_pcm mac80211 ghash_clmulni_intel snd_page_alloc aesni_intel snd_seq_midi xts snd_seq_midi_event aes_x86_64 rfcomm snd_rawmidi parport_pc bnep lrw snd_seq uvcvideo i2c_algo_bit ppdev gf128mul iwlwifi snd_timer drm_kms_helper ablk_helper cryptd drm snd_seq_device videobuf2_vmalloc psmouse videobuf2_memops snd cfg80211 btusb videobuf2_core soundcore videodev lp bluetooth samsung_laptop wmi microcode mei serio_raw mac_hid video hid_generic lpc_ich parport usbhid hid r8169
> [ 137.062143] Pid: 2706, comm: kworker/u:15 Tainted: G D W 3.8.0-rc2-next20130109-1-iniza-generic #1
> [ 137.062144] Call Trace:
> [ 137.062156] [<ffffffff8105860f>] warn_slowpath_common+0x7f/0xc0
> [ 137.062159] [<ffffffff8135b1ea>] ? ioread32+0x3a/0x40
> [ 137.062162] [<ffffffff8105866a>] warn_slowpath_null+0x1a/0x20
> [ 137.062168] [<ffffffffa0076be6>] mei_cl_unlink+0x86/0x90 [mei]
> [ 137.062173] [<ffffffffa0071325>] mei_reset+0xc5/0x240 [mei]
> [ 137.062178] [<ffffffffa0073703>] mei_pci_resume+0xa3/0x110 [mei]
> [ 137.062183] [<ffffffff81379cae>] pci_pm_resume+0x7e/0xe0
> [ 137.062185] [<ffffffff81379c30>] ? pci_pm_thaw+0x80/0x80
> [ 137.062189] [<ffffffff8145a415>] dpm_run_callback.isra.6+0x25/0x50
> [ 137.062192] [<ffffffff8145a6cf>] device_resume+0x9f/0x140
> [ 137.062194] [<ffffffff8145a791>] async_resume+0x21/0x50
> [ 137.062200] [<ffffffff810858b0>] async_run_entry_fn+0x90/0x1c0
> [ 137.062203] [<ffffffff810778e5>] process_one_work+0x155/0x460
> [ 137.062207] [<ffffffff81078578>] worker_thread+0x168/0x400
> [ 137.062210] [<ffffffff81078410>] ? manage_workers+0x2b0/0x2b0
> [ 137.062214] [<ffffffff8107d9f0>] kthread+0xc0/0xd0
> [ 137.062218] [<ffffffff8107d930>] ? flush_kthread_worker+0xb0/0xb0
> [ 137.062222] [<ffffffff816bac6c>] ret_from_fork+0x7c/0xb0
> [ 137.062228] [<ffffffff8107d930>] ? flush_kthread_worker+0xb0/0xb0
>
> Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Can you please apply this patch to char-misc-next?
I am hitting it again while doing other regression testing!
- Sedat -
[1] http://marc.info/?l=linux-kernel&m=135817238702217&w=2
> ---
> V2: fix a typo in the comment
>
> drivers/misc/mei/client.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c
> index d566dd8..a921001 100644
> --- a/drivers/misc/mei/client.c
> +++ b/drivers/misc/mei/client.c
> @@ -312,8 +312,9 @@ int mei_cl_unlink(struct mei_cl *cl)
> if (!cl)
> return 0;
>
> - if (WARN_ON(!cl->dev))
> - return -EINVAL;
> + /* wd and amthif might not be initialized */
> + if (!cl->dev)
> + return 0;
>
> dev = cl->dev;
>
> --
> 1.7.4.4
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [char-misc-next V2] mei: drop the warning when cl is not initialized during unlinking
2013-01-14 14:14 ` Sedat Dilek
@ 2013-01-14 14:32 ` Greg KH
2013-01-14 14:55 ` Sedat Dilek
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2013-01-14 14:32 UTC (permalink / raw)
To: Sedat Dilek; +Cc: Tomas Winkler, arnd, alan, linux-kernel
On Mon, Jan 14, 2013 at 03:14:50PM +0100, Sedat Dilek wrote:
> On Thu, Jan 10, 2013 at 4:32 PM, Tomas Winkler <tomas.winkler@intel.com> wrote:
> > On systems where wd and amthif is not initialized
> > we will hit cl->dev == NULL. This condition is okay
> > so we don't need to be laud about it.
> >
> > Fixes the follwing warning during suspend
> > [ 137.061985] WARNING: at drivers/misc/mei/client.c:315 mei_cl_unlink+0x86/0x90 [mei]()
> > [ 137.061986] Hardware name: 530U3BI/530U4BI/530U4BH
> > [ 137.062140] Modules linked in: snd_hda_codec_hdmi snd_hda_codec_realtek joydev coretemp kvm_intel snd_hda_intel snd_hda_codec kvm arc4 iwldvm snd_hwdep i915 snd_pcm mac80211 ghash_clmulni_intel snd_page_alloc aesni_intel snd_seq_midi xts snd_seq_midi_event aes_x86_64 rfcomm snd_rawmidi parport_pc bnep lrw snd_seq uvcvideo i2c_algo_bit ppdev gf128mul iwlwifi snd_timer drm_kms_helper ablk_helper cryptd drm snd_seq_device videobuf2_vmalloc psmouse videobuf2_memops snd cfg80211 btusb videobuf2_core soundcore videodev lp bluetooth samsung_laptop wmi microcode mei serio_raw mac_hid video hid_generic lpc_ich parport usbhid hid r8169
> > [ 137.062143] Pid: 2706, comm: kworker/u:15 Tainted: G D W 3.8.0-rc2-next20130109-1-iniza-generic #1
> > [ 137.062144] Call Trace:
> > [ 137.062156] [<ffffffff8105860f>] warn_slowpath_common+0x7f/0xc0
> > [ 137.062159] [<ffffffff8135b1ea>] ? ioread32+0x3a/0x40
> > [ 137.062162] [<ffffffff8105866a>] warn_slowpath_null+0x1a/0x20
> > [ 137.062168] [<ffffffffa0076be6>] mei_cl_unlink+0x86/0x90 [mei]
> > [ 137.062173] [<ffffffffa0071325>] mei_reset+0xc5/0x240 [mei]
> > [ 137.062178] [<ffffffffa0073703>] mei_pci_resume+0xa3/0x110 [mei]
> > [ 137.062183] [<ffffffff81379cae>] pci_pm_resume+0x7e/0xe0
> > [ 137.062185] [<ffffffff81379c30>] ? pci_pm_thaw+0x80/0x80
> > [ 137.062189] [<ffffffff8145a415>] dpm_run_callback.isra.6+0x25/0x50
> > [ 137.062192] [<ffffffff8145a6cf>] device_resume+0x9f/0x140
> > [ 137.062194] [<ffffffff8145a791>] async_resume+0x21/0x50
> > [ 137.062200] [<ffffffff810858b0>] async_run_entry_fn+0x90/0x1c0
> > [ 137.062203] [<ffffffff810778e5>] process_one_work+0x155/0x460
> > [ 137.062207] [<ffffffff81078578>] worker_thread+0x168/0x400
> > [ 137.062210] [<ffffffff81078410>] ? manage_workers+0x2b0/0x2b0
> > [ 137.062214] [<ffffffff8107d9f0>] kthread+0xc0/0xd0
> > [ 137.062218] [<ffffffff8107d930>] ? flush_kthread_worker+0xb0/0xb0
> > [ 137.062222] [<ffffffff816bac6c>] ret_from_fork+0x7c/0xb0
> > [ 137.062228] [<ffffffff8107d930>] ? flush_kthread_worker+0xb0/0xb0
> >
> > Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
> > Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
>
> Can you please apply this patch to char-misc-next?
> I am hitting it again while doing other regression testing!
Please be patient, it will get there soon.
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [char-misc-next V2] mei: drop the warning when cl is not initialized during unlinking
2013-01-14 14:32 ` Greg KH
@ 2013-01-14 14:55 ` Sedat Dilek
2013-01-14 15:12 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Sedat Dilek @ 2013-01-14 14:55 UTC (permalink / raw)
To: Greg KH, Linus Torvalds; +Cc: Tomas Winkler, arnd, alan, linux-kernel
On Mon, Jan 14, 2013 at 3:32 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, Jan 14, 2013 at 03:14:50PM +0100, Sedat Dilek wrote:
>> On Thu, Jan 10, 2013 at 4:32 PM, Tomas Winkler <tomas.winkler@intel.com> wrote:
>> > On systems where wd and amthif is not initialized
>> > we will hit cl->dev == NULL. This condition is okay
>> > so we don't need to be laud about it.
>> >
>> > Fixes the follwing warning during suspend
>> > [ 137.061985] WARNING: at drivers/misc/mei/client.c:315 mei_cl_unlink+0x86/0x90 [mei]()
>> > [ 137.061986] Hardware name: 530U3BI/530U4BI/530U4BH
>> > [ 137.062140] Modules linked in: snd_hda_codec_hdmi snd_hda_codec_realtek joydev coretemp kvm_intel snd_hda_intel snd_hda_codec kvm arc4 iwldvm snd_hwdep i915 snd_pcm mac80211 ghash_clmulni_intel snd_page_alloc aesni_intel snd_seq_midi xts snd_seq_midi_event aes_x86_64 rfcomm snd_rawmidi parport_pc bnep lrw snd_seq uvcvideo i2c_algo_bit ppdev gf128mul iwlwifi snd_timer drm_kms_helper ablk_helper cryptd drm snd_seq_device videobuf2_vmalloc psmouse videobuf2_memops snd cfg80211 btusb videobuf2_core soundcore videodev lp bluetooth samsung_laptop wmi microcode mei serio_raw mac_hid video hid_generic lpc_ich parport usbhid hid r8169
>> > [ 137.062143] Pid: 2706, comm: kworker/u:15 Tainted: G D W 3.8.0-rc2-next20130109-1-iniza-generic #1
>> > [ 137.062144] Call Trace:
>> > [ 137.062156] [<ffffffff8105860f>] warn_slowpath_common+0x7f/0xc0
>> > [ 137.062159] [<ffffffff8135b1ea>] ? ioread32+0x3a/0x40
>> > [ 137.062162] [<ffffffff8105866a>] warn_slowpath_null+0x1a/0x20
>> > [ 137.062168] [<ffffffffa0076be6>] mei_cl_unlink+0x86/0x90 [mei]
>> > [ 137.062173] [<ffffffffa0071325>] mei_reset+0xc5/0x240 [mei]
>> > [ 137.062178] [<ffffffffa0073703>] mei_pci_resume+0xa3/0x110 [mei]
>> > [ 137.062183] [<ffffffff81379cae>] pci_pm_resume+0x7e/0xe0
>> > [ 137.062185] [<ffffffff81379c30>] ? pci_pm_thaw+0x80/0x80
>> > [ 137.062189] [<ffffffff8145a415>] dpm_run_callback.isra.6+0x25/0x50
>> > [ 137.062192] [<ffffffff8145a6cf>] device_resume+0x9f/0x140
>> > [ 137.062194] [<ffffffff8145a791>] async_resume+0x21/0x50
>> > [ 137.062200] [<ffffffff810858b0>] async_run_entry_fn+0x90/0x1c0
>> > [ 137.062203] [<ffffffff810778e5>] process_one_work+0x155/0x460
>> > [ 137.062207] [<ffffffff81078578>] worker_thread+0x168/0x400
>> > [ 137.062210] [<ffffffff81078410>] ? manage_workers+0x2b0/0x2b0
>> > [ 137.062214] [<ffffffff8107d9f0>] kthread+0xc0/0xd0
>> > [ 137.062218] [<ffffffff8107d930>] ? flush_kthread_worker+0xb0/0xb0
>> > [ 137.062222] [<ffffffff816bac6c>] ret_from_fork+0x7c/0xb0
>> > [ 137.062228] [<ffffffff8107d930>] ? flush_kthread_worker+0xb0/0xb0
>> >
>> > Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
>> > Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
>> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
>>
>> Can you please apply this patch to char-misc-next?
>> I am hitting it again while doing other regression testing!
>
> Please be patient, it will get there soon.
>
The same answer I got for the report/testing of [1], it is still not
in mainline.
Yes, I have seen your pull-request for char-misc-linus of today, but
why does this takes weeks to apply?
*** Why don't you treat (reported and tested) regressions with a
higher priority? ***
This has nothing to do with patience! You steal other people's time!
Hitting other regressions while doing bisecting is really no fun.
( ...and [GIT-PULL] requests are cheap... or do you really think we
will wait until you emptied your inbox? )
It makes me angry to fell over and over the same sh*t.
The consequence is...
CONFIG_INTEL_MEI=n
Test your code by yourself!
In your endless time you will find a minute to apply [2] as well (sarcasm off).
23-Dec-2012 [3]...
- Sedat -
[1] http://git.kernel.org/?p=linux/kernel/git/gregkh/char-misc.git;a=commitdiff;h=e6028db0146cf5a68dbd1508225ea49840997880
[2] https://patchwork.kernel.org/patch/1952421/
[3] http://lkml.org/lkml/2012/12/23/49
> greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [char-misc-next V2] mei: drop the warning when cl is not initialized during unlinking
2013-01-14 14:55 ` Sedat Dilek
@ 2013-01-14 15:12 ` Greg KH
2013-01-14 15:34 ` Sedat Dilek
2013-01-15 1:46 ` Chen Gang F T
0 siblings, 2 replies; 7+ messages in thread
From: Greg KH @ 2013-01-14 15:12 UTC (permalink / raw)
To: Sedat Dilek; +Cc: Linus Torvalds, Tomas Winkler, arnd, alan, linux-kernel
On Mon, Jan 14, 2013 at 03:55:44PM +0100, Sedat Dilek wrote:
> On Mon, Jan 14, 2013 at 3:32 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Mon, Jan 14, 2013 at 03:14:50PM +0100, Sedat Dilek wrote:
> >> On Thu, Jan 10, 2013 at 4:32 PM, Tomas Winkler <tomas.winkler@intel.com> wrote:
> >>
> >> Can you please apply this patch to char-misc-next?
> >> I am hitting it again while doing other regression testing!
> >
> > Please be patient, it will get there soon.
> >
>
> The same answer I got for the report/testing of [1], it is still not
> in mainline.
> Yes, I have seen your pull-request for char-misc-linus of today, but
> why does this takes weeks to apply?
"Weeks"? You do realize this was sent to me over a holliday break, one
in which I was on vacation? I only returned a week ago, to over 1500
patches to sift through and process.
And, I did that within 4 days, and sent the needed fix off to Linus
within 7 days of returning.
If you think you can do better than that, wonderful, I would love for
you to start out reviewing code and helping with handling stuff like
that. Please do so before complaining about anything.
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [char-misc-next V2] mei: drop the warning when cl is not initialized during unlinking
2013-01-14 15:12 ` Greg KH
@ 2013-01-14 15:34 ` Sedat Dilek
2013-01-15 1:46 ` Chen Gang F T
1 sibling, 0 replies; 7+ messages in thread
From: Sedat Dilek @ 2013-01-14 15:34 UTC (permalink / raw)
To: Greg KH; +Cc: Linus Torvalds, Tomas Winkler, arnd, alan, linux-kernel
On Mon, Jan 14, 2013 at 4:12 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, Jan 14, 2013 at 03:55:44PM +0100, Sedat Dilek wrote:
>> On Mon, Jan 14, 2013 at 3:32 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
>> > On Mon, Jan 14, 2013 at 03:14:50PM +0100, Sedat Dilek wrote:
>> >> On Thu, Jan 10, 2013 at 4:32 PM, Tomas Winkler <tomas.winkler@intel.com> wrote:
>> >>
>> >> Can you please apply this patch to char-misc-next?
>> >> I am hitting it again while doing other regression testing!
>> >
>> > Please be patient, it will get there soon.
>> >
>>
>> The same answer I got for the report/testing of [1], it is still not
>> in mainline.
>> Yes, I have seen your pull-request for char-misc-linus of today, but
>> why does this takes weeks to apply?
>
> "Weeks"? You do realize this was sent to me over a holliday break, one
> in which I was on vacation? I only returned a week ago, to over 1500
> patches to sift through and process.
>
> And, I did that within 4 days, and sent the needed fix off to Linus
> within 7 days of returning.
>
> If you think you can do better than that, wonderful, I would love for
> you to start out reviewing code and helping with handling stuff like
> that. Please do so before complaining about anything.
>
The MAINTAINERS file lists a co-maintainer. Not sure what his job is.
In every company when people are on holidays, the work continues.
Speaking in general... regression fixes (freezing my machine on reboot
is one!) should be treat differently - faster!
I am testing GIT tree's before they enter mainline or Linux-Next.
And I am doing this in my free-time - I am not paid for it.
In a scrum talk the speaker called that (time) "units" (of work
especially in OSS projects)... "lost of free-time".
Maybe, I should look for a different hobby and wait til -rc4 is
released to be on the safe side of life.
In another email I was reflecting on a "arbritration board".
Good Mr. Torvalds said in an interview "I don't read code anymore"...
but what was with these fs/blkdev changes late in 3.7 cycle :-)?
There seems to be no rules except yours.
Right, you have the reponsibilty.
The last week I played with Linux Test Project and I still do NOT know
how to (really) test my kernels!
In each kernel-release (even rc) we read "please test" - but how?
Noone tells you this.
( A different story... )
Just some thoughts... for free.
- Sedat -
> greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [char-misc-next V2] mei: drop the warning when cl is not initialized during unlinking
2013-01-14 15:12 ` Greg KH
2013-01-14 15:34 ` Sedat Dilek
@ 2013-01-15 1:46 ` Chen Gang F T
1 sibling, 0 replies; 7+ messages in thread
From: Chen Gang F T @ 2013-01-15 1:46 UTC (permalink / raw)
To: Greg KH
Cc: Sedat Dilek, Linus Torvalds, Tomas Winkler, arnd, alan,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 797 bytes --]
于 2013年01月14日 23:12, Greg KH 写道:
> If you think you can do better than that, wonderful, I would love for
> you to start out reviewing code and helping with handling stuff like
> that. Please do so before complaining about anything.
it seems, he is not complaining, maybe for him, he has to treat it as
an urgent thing.
and for every member, it is necessary to have a rest, so can keep our
contributes (work) with efficiency and sustainable.
so, please give more understanding with each other, so can make our
cooperation better and better.
by the way:
maybe it is necessary to think of a backup working flow to process
such kind of issues: "how to make the negative effect lowest, when
important members have to have a necessary rest".
--
Chen Gang
Flying Transformer
[-- Attachment #2: chen_gang_flying_transformer.vcf --]
[-- Type: text/x-vcard, Size: 67 bytes --]
begin:vcard
fn:Chen Gang
n:;Chen Gang
version:2.1
end:vcard
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-01-15 1:46 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-10 15:32 [char-misc-next V2] mei: drop the warning when cl is not initialized during unlinking Tomas Winkler
2013-01-14 14:14 ` Sedat Dilek
2013-01-14 14:32 ` Greg KH
2013-01-14 14:55 ` Sedat Dilek
2013-01-14 15:12 ` Greg KH
2013-01-14 15:34 ` Sedat Dilek
2013-01-15 1:46 ` Chen Gang F T
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox