From: Stephen Warren <swarren@wwwdotorg.org>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Stephen Warren <swarren@nvidia.com>,
Anmar Oueja <anmar.oueja@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
Patrice Chotard <patrice.chotard@st.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 4/4] pinctrl/abx500: add AB8500 pinctrl driver
Date: Tue, 15 Jan 2013 11:10:53 -0700 [thread overview]
Message-ID: <50F59BAD.6000609@wwwdotorg.org> (raw)
In-Reply-To: <1358242994-5200-1-git-send-email-linus.walleij@stericsson.com>
On 01/15/2013 02:43 AM, Linus Walleij wrote:
> From: Patrice Chotard <patrice.chotard@st.com>
>
> This adds a subdriver for the AB8500 pinctrl portions.
> diff --git a/drivers/pinctrl/pinctrl-ab8500.c b/drivers/pinctrl/pinctrl-ab8500.c
> +static struct abx500_pinctrl_soc_data ab8500_ranges_soc = {
> + .gpio_ranges = ab8500_pinranges,
> + .gpio_num_ranges = ARRAY_SIZE(ab8500_pinranges),
> + .pins = ab8500_ranges_pins,
> + .npins = ARRAY_SIZE(ab8500_ranges_pins),
> + .functions = ab8500_ranges_functions,
> + .nfunctions = ARRAY_SIZE(ab8500_ranges_functions),
> + .groups = ab8500_ranges_groups,
> + .ngroups = ARRAY_SIZE(ab8500_ranges_groups),
> + .alternate_functions = ab8500_alternate_functions,
> + .gpio_irq_cluster = ab8500_gpio_irq_cluster,
> + .ngpio_irq_cluster = ARRAY_SIZE(ab8500_gpio_irq_cluster),
> + .irq_gpio_rising_offset = AB8500_INT_GPIO6R,
> + .irq_gpio_falling_offset = AB8500_INT_GPIO6F,
> + .irq_gpio_factor = 1,
> +};
> +
> +void __devinit
> +abx500_pinctrl_ab8500_init(struct abx500_pinctrl_soc_data **soc)
> +{
> + *soc = &ab8500_ranges_soc;
> +}
"ranges" in that variable name seems a little odd since it's much more
than ranges... But otherwise, this patch, very briefly,
Reviewed-by: Stephen Warren <swarren@nvidia.com>
prev parent reply other threads:[~2013-01-15 18:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 9:43 [PATCH 4/4] pinctrl/abx500: add AB8500 pinctrl driver Linus Walleij
2013-01-15 18:10 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F59BAD.6000609@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=anmar.oueja@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrice.chotard@st.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox