From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756332Ab3AOUqW (ORCPT ); Tue, 15 Jan 2013 15:46:22 -0500 Received: from mail.free-electrons.com ([94.23.35.102]:35791 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754888Ab3AOUqV (ORCPT ); Tue, 15 Jan 2013 15:46:21 -0500 Message-ID: <50F5C00B.10108@free-electrons.com> Date: Tue, 15 Jan 2013 21:46:03 +0100 From: Gregory CLEMENT User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Cong Ding , Mike Turquette CC: Jason Cooper , Thomas Petazzoni , linux-kernel@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3] clk: mvebu/clk-cpu.c: fix memory leakage References: <1358183892-28928-1-git-send-email-dinggnu@gmail.com> <50F563EC.3030804@free-electrons.com> <20130115152307.GA25615@gmail.com> <20130115153716.GF13433@titan.lakedaemon.net> <50F584F5.6030007@free-electrons.com> <20130115182629.GB7211@gmail.com> <50F5A1A9.2030803@free-electrons.com> <20130115184423.GC7211@gmail.com> In-Reply-To: <20130115184423.GC7211@gmail.com> X-Enigmail-Version: 1.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/15/2013 07:44 PM, Cong Ding wrote: > the variable cpuclk and clk_name should be properly freed when error happens. Dear Cong Ding, Thanks for you efforts! I am happy with this patch and I tested it on the Armada XP DB board, so you can now add my: Acked-by: Gregory CLEMENT Mike, could you take this patch for 3.8-rc fixes? If you prefer, Jason agrees to take it, but you probably didn't notice it, because he uses your former(and no more valid) email when he wrote this. Thanks, Gregory > > Signed-off-by: Cong Ding > Acked-by: Jason Cooper > --- > drivers/clk/mvebu/clk-cpu.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/mvebu/clk-cpu.c b/drivers/clk/mvebu/clk-cpu.c > index ff004578..9dd2551 100644 > --- a/drivers/clk/mvebu/clk-cpu.c > +++ b/drivers/clk/mvebu/clk-cpu.c > @@ -124,7 +124,7 @@ void __init of_cpu_clk_setup(struct device_node *node) > > clks = kzalloc(ncpus * sizeof(*clks), GFP_KERNEL); > if (WARN_ON(!clks)) > - return; > + goto clks_out; > > for_each_node_by_type(dn, "cpu") { > struct clk_init_data init; > @@ -134,11 +134,11 @@ void __init of_cpu_clk_setup(struct device_node *node) > int cpu, err; > > if (WARN_ON(!clk_name)) > - return; > + goto bail_out; > > err = of_property_read_u32(dn, "reg", &cpu); > if (WARN_ON(err)) > - return; > + goto bail_out; > > sprintf(clk_name, "cpu%d", cpu); > parent_clk = of_clk_get(node, 0); > @@ -167,6 +167,9 @@ void __init of_cpu_clk_setup(struct device_node *node) > return; > bail_out: > kfree(clks); > + while(ncpus--) > + kfree(cpuclk[ncpus].clk_name); > +clks_out: > kfree(cpuclk); > } > > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com