public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Samuel <chris@csamuel.org>
To: linux-kernel@vger.kernel.org
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	dhowells@redhat.com, Michal Marek <mmarek@suse.cz>
Subject: Re: [RFC] [PATCH] Disable INSTALL_MOD_STRIP when CONFIG_MODULE_SIG set
Date: Wed, 16 Jan 2013 10:27:58 +1100	[thread overview]
Message-ID: <50F5E5FE.9040304@csamuel.org> (raw)
In-Reply-To: <50F46C36.3060403@csamuel.org>

/* Please CC, not on LKML */

On 15/01/13 07:36, Chris Samuel wrote:

> So we set mod_strip_cmd to be true to prevent it stripping kernel
> modules, just as happens if INSTALL_MOD_STRIP is not passed.

Ignore this patch, sorry for the noise.

I'd tested by comparing the modules produced by the build system in this
patch with the ones produced by make-kpkg and missed the fact that
*after* doing the module install make-kpkg then runs objcopy on the
modules to copy out the debug sections for a debug package and then uses
objcopy to remove the same debug sections (along with the signature)
from the ones in the main package. :-(

I'd also misread the order that the strip and signing happens, so that
the kernel signs after stripping, so there is nothing to fix.

Interestingly stripping them only saves 1MB out of 120MB for me, so it
hardly seems worth doing.

-- 
 Chris Samuel  :  http://www.csamuel.org/  :  Melbourne, VIC

      reply	other threads:[~2013-01-15 23:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-14 20:36 [RFC] [PATCH] Disable INSTALL_MOD_STRIP when CONFIG_MODULE_SIG set Chris Samuel
2013-01-15 23:27 ` Chris Samuel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F5E5FE.9040304@csamuel.org \
    --to=chris@csamuel.org \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox