From: "H. Peter Anvin" <hpa@linux.intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Ondrej Zary <linux@rainbow-software.org>,
dmitry.torokhov@gmail.com, Alan Cox <alan@lxorguk.ukuu.org.uk>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
linux-kernel@vger.kernel.org
Subject: Re: your patch "x86, 8042: Enable A20 using KBC to fix S3 resume on some MSI laptops"
Date: Tue, 15 Jan 2013 17:16:33 -0800 [thread overview]
Message-ID: <50F5FF71.5080403@linux.intel.com> (raw)
In-Reply-To: <50F3D7A302000078000B531D@nat28.tlf.novell.com>
On 01/14/2013 01:02 AM, Jan Beulich wrote:
>>
>> What's "properly"? Doing extra 8042 detection somewhere else does not look
>> right.
>
> Why?
>
Because it is time consuming, and threatens to step on things.
Enabling A20 is one thing, but this is something else... if we have the
KBC, we want to enable A20 *again* just in case. Having the i8042 code
in one place makes sense to me. This doesn't have to be done early.
The affected systems are *extremely* unlikely to ever be run without the
i8042 driver loaded, and the failure mode benign enough (if you actually
want to run a specific laptop without the keyboard driver, you can't
suspend it) that there really is no point to have yet another driver for
the same hardware that would stomp on each other.
-hpa
prev parent reply other threads:[~2013-01-16 1:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 8:08 your patch "x86, 8042: Enable A20 using KBC to fix S3 resume on some MSI laptops" Jan Beulich
2013-01-14 8:29 ` Ondrej Zary
2013-01-14 8:37 ` Jan Beulich
2013-01-14 8:54 ` Ondrej Zary
2013-01-14 9:02 ` Jan Beulich
2013-01-16 1:16 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F5FF71.5080403@linux.intel.com \
--to=hpa@linux.intel.com \
--cc=JBeulich@suse.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox