[GIT PULL] extcon for 3.8-rc4

[GIT PULL] extcon for 3.8-rc4

[Chanwoo Choi]

Hi Greg,

This is the extcon pull request for Linux 3.8-rc4.

Please pull extcon with following updates:

Update to max77693/max8997 extcon driver:
- Using MHL_TA cable for charging.
- Support JIG cable.
- Support Dock-Audio device for playing music and button of device.
- Support Dock-Smart device for desktop mode with mouse/keyboard.
- Set default UART/USB path on probe().
- Check the state/type of cable after completing initialization.
- Code clean to remove duplicate code and bug fix related to sequence of interrupt.
- Fix irq_flag of max8997/max77693 driver.

Update to arizona extcon driver:
- Headphone measurements.
- Alternative detection mechanism for non-default system designs.
- Microphone clamp integration.
- Support for additional detection pin.
- MICBIAS rise time configuration.

Thanks in advance for pulling,

Best regards,
Chanwoo Choi

The following changes since commit 9931faca02c604c22335f5a935a501bb2ace6e20:

  Linux 3.8-rc3 (2013-01-09 18:59:55 -0800)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git tags/extcon-3.8-rc4

for you to fetch changes up to 689557d3c7045320958d5bc4141088f7b4dff7ba:

  mfd: wm5102: Add microphone clamp control registers (2013-01-15 15:42:18 +0900)

----------------------------------------------------------------
Chanwoo Choi (9):
      extcon: max77693: Remove duplicate code by making function
      extcon: max77693: Add support MHL_TA cable for charging battery
      extcon: max77693: Add support jig cable
      extcon: max77693: Add support dock device and buttons
      extcon: max77693: Check the state/type of cable after boot completed
      extcon: max8997/max77693: Support IRQF_NO_SUSPEND flag for interrupt
      extcon: max77693: Set default uart/usb path by using platform data
      extcon: max77693: Fix bug when detecting MHL/Dock-Audio with USB/TA cable
      extcon: max77693: Add support Dock-Smart device for desktop mode

Mark Brown (11):
      extcon: arizona: Convert to devm_input_allocate_device()
      extcon: arizona: Remove duplicate mic ramp configuration
      extcon: arizona: Only set GPIO if it has been requested
      extcon: arizona: Allow configuration of MICBIAS rise time
      extcon: arizona: Use microphone clamp function if available
      extcon: arizona: Support use of GPIO5 as an input to jack detection
      extcon: arizona: Enable basic headphone identification
      extcon: Simple code motion supporting future work.
      extcon: arizona: Support HPDET based accessory identification
      extcon: arizona: Support direct microphone measurement via HPDET
      mfd: wm5102: Add microphone clamp control registers

 drivers/extcon/extcon-arizona.c       | 634 +++++++++++++++++++++--
 drivers/extcon/extcon-max77693.c      | 920 +++++++++++++++++++++++++---------
 drivers/extcon/extcon-max8997.c       |   6 +-
 drivers/mfd/wm5102-tables.c           |  10 +
 include/linux/mfd/arizona/core.h      |   4 +-
 include/linux/mfd/arizona/pdata.h     |  12 +
 include/linux/mfd/arizona/registers.h |  48 ++
 include/linux/mfd/max77693-private.h  |  86 ++++
 include/linux/mfd/max77693.h          |   9 +
 9 files changed, 1439 insertions(+), 290 deletions(-)

Re: [GIT PULL] extcon for 3.8-rc4

[Greg KH]

On Tue, Jan 15, 2013 at 04:34:18PM +0900, Chanwoo Choi wrote:
> Hi Greg,
> 
> This is the extcon pull request for Linux 3.8-rc4.
> 
> Please pull extcon with following updates:
> 
> Update to max77693/max8997 extcon driver:
> - Using MHL_TA cable for charging.
> - Support JIG cable.
> - Support Dock-Audio device for playing music and button of device.
> - Support Dock-Smart device for desktop mode with mouse/keyboard.
> - Set default UART/USB path on probe().
> - Check the state/type of cable after completing initialization.
> - Code clean to remove duplicate code and bug fix related to sequence of interrupt.
> - Fix irq_flag of max8997/max77693 driver.
> 
> Update to arizona extcon driver:
> - Headphone measurements.
> - Alternative detection mechanism for non-default system designs.
> - Microphone clamp integration.
> - Support for additional detection pin.
> - MICBIAS rise time configuration.
> 
> Thanks in advance for pulling,

This request is for inclusion in 3.9, right?  This seems much too big
for 3.8 at the moment.

greg k-h

Re: [GIT PULL] extcon for 3.8-rc4

[Greg KH]

On Tue, Jan 15, 2013 at 09:09:20PM +0900, Chanwoo Choi wrote:
> On Tuesday, January 15, 2013, Greg KH wrote:
> 
>     On Tue, Jan 15, 2013 at 04:34:18PM +0900, Chanwoo Choi wrote:
>     > Hi Greg,
>     >
>     > This is the extcon pull request for Linux 3.8-rc4.
>     >
>     > Please pull extcon with following updates:
>     >
>     > Update to max77693/max8997 extcon driver:
>     > - Using MHL_TA cable for charging.
>     > - Support JIG cable.
>     > - Support Dock-Audio device for playing music and button of device.
>     > - Support Dock-Smart device for desktop mode with mouse/keyboard.
>     > - Set default UART/USB path on probe().
>     > - Check the state/type of cable after completing initialization.
>     > - Code clean to remove duplicate code and bug fix related to sequence of
>     interrupt.
>     > - Fix irq_flag of max8997/max77693 driver.
>     >
>     > Update to arizona extcon driver:
>     > - Headphone measurements.
>     > - Alternative detection mechanism for non-default system designs.
>     > - Microphone clamp integration.
>     > - Support for additional detection pin.
>     > - MICBIAS rise time configuration.
>     >
>     > Thanks in advance for pulling,
> 
>     This request is for inclusion in 3.9, right?  This seems much too big
>     for 3.8 at the moment.
> 
>  
> If you think that, I agree your opinion about including this request in 3.9.

That's really up to you, as a subsystem maintainer, to decide about.
You need to take bugfixes and ask for them to be included in the 3.8,
and new features and other work, for 3.9.

So can you please go over these patches and ensure that none of them are
ok for 3.8, and all are fine for 3.9?

Also, as Mark pointed out, you really need to get your tree(s) into
linux-next, can you work on doing that as well?

thanks,

greg k-h

Re: [GIT PULL] extcon for 3.8-rc4

[Mark Brown]

On Tue, Jan 15, 2013 at 04:13:56AM -0800, Greg KH wrote:

> So can you please go over these patches and ensure that none of them are
> ok for 3.8, and all are fine for 3.9?

I'd not expect any of the arizona patches to be v3.8 material FWIW.

Re: [GIT PULL] extcon for 3.8-rc4

[Greg KH]

On Tue, Jan 15, 2013 at 10:23:44PM +0900, Chanwoo Choi wrote:
> On Tuesday, January 15, 2013, Greg KH wrote:
> 
>     On Tue, Jan 15, 2013 at 09:09:20PM +0900, Chanwoo Choi wrote:
>     > On Tuesday, January 15, 2013, Greg KH wrote:
>     >
>     >     On Tue, Jan 15, 2013 at 04:34:18PM +0900, Chanwoo Choi wrote:
>     >     > Hi Greg,
>     >     >
>     >     > This is the extcon pull request for Linux 3.8-rc4.
>     >     >
>     >     > Please pull extcon with following updates:
>     >     >
>     >     > Update to max77693/max8997 extcon driver:
>     >     > - Using MHL_TA cable for charging.
>     >     > - Support JIG cable.
>     >     > - Support Dock-Audio device for playing music and button of device.
>     >     > - Support Dock-Smart device for desktop mode with mouse/keyboard.
>     >     > - Set default UART/USB path on probe().
>     >     > - Check the state/type of cable after completing initialization.
>     >     > - Code clean to remove duplicate code and bug fix related to
>     sequence of
>     >     interrupt.
>     >     > - Fix irq_flag of max8997/max77693 driver.
>     >     >
>     >     > Update to arizona extcon driver:
>     >     > - Headphone measurements.
>     >     > - Alternative detection mechanism for non-default system designs.
>     >     > - Microphone clamp integration.
>     >     > - Support for additional detection pin.
>     >     > - MICBIAS rise time configuration.
>     >     >
>     >     > Thanks in advance for pulling,
>     >
>     >     This request is for inclusion in 3.9, right?  This seems much too big
>     >     for 3.8 at the moment.
>     >
>     >  
>     > If you think that, I agree your opinion about including this request in
>     3.9.
> 
>     That's really up to you, as a subsystem maintainer, to decide about.
>     You need to take bugfixes and ask for them to be included in the 3.8,
>     and new features and other work, for 3.9.
> 
>  OK, I will resend pull-request to include only bugfixes patch in 3.8.
> After released v3.8-rc7 or 3.8-rc8 kernel, I will send pull-request of extcon
> to include new feature patches of extcon driver in 3.9.

No, you can send me that pull request now as well, I have two different
branches, one to go to Linus for this release, and one for the next one.
Both of them show up in linux-next.  You should have the same.

So you can send me two pull requests now, does that make more sense?

thanks,

greg k-h

Re: [GIT PULL] extcon for 3.8-rc4

[Chanwoo Choi]

On 01/15/2013 10:49 PM, Greg KH wrote:
> On Tue, Jan 15, 2013 at 10:23:44PM +0900, Chanwoo Choi wrote:
>> On Tuesday, January 15, 2013, Greg KH wrote:
>>
>>     On Tue, Jan 15, 2013 at 09:09:20PM +0900, Chanwoo Choi wrote:
>>     > On Tuesday, January 15, 2013, Greg KH wrote:
>>     >
>>     >     On Tue, Jan 15, 2013 at 04:34:18PM +0900, Chanwoo Choi wrote:
>>     >     > Hi Greg,
>>     >     >
>>     >     > This is the extcon pull request for Linux 3.8-rc4.
>>     >     >
>>     >     > Please pull extcon with following updates:
>>     >     >
>>     >     > Update to max77693/max8997 extcon driver:
>>     >     > - Using MHL_TA cable for charging.
>>     >     > - Support JIG cable.
>>     >     > - Support Dock-Audio device for playing music and button of device.
>>     >     > - Support Dock-Smart device for desktop mode with mouse/keyboard.
>>     >     > - Set default UART/USB path on probe().
>>     >     > - Check the state/type of cable after completing initialization.
>>     >     > - Code clean to remove duplicate code and bug fix related to
>>     sequence of
>>     >     interrupt.
>>     >     > - Fix irq_flag of max8997/max77693 driver.
>>     >     >
>>     >     > Update to arizona extcon driver:
>>     >     > - Headphone measurements.
>>     >     > - Alternative detection mechanism for non-default system designs.
>>     >     > - Microphone clamp integration.
>>     >     > - Support for additional detection pin.
>>     >     > - MICBIAS rise time configuration.
>>     >     >
>>     >     > Thanks in advance for pulling,
>>     >
>>     >     This request is for inclusion in 3.9, right?  This seems much too big
>>     >     for 3.8 at the moment.
>>     >
>>     >  
>>     > If you think that, I agree your opinion about including this request in
>>     3.9.
>>
>>     That's really up to you, as a subsystem maintainer, to decide about.
>>     You need to take bugfixes and ask for them to be included in the 3.8,
>>     and new features and other work, for 3.9.
>>
>>  OK, I will resend pull-request to include only bugfixes patch in 3.8.
>> After released v3.8-rc7 or 3.8-rc8 kernel, I will send pull-request of extcon
>> to include new feature patches of extcon driver in 3.9.
> 
> No, you can send me that pull request now as well, I have two different
> branches, one to go to Linus for this release, and one for the next one.
> Both of them show up in linux-next.  You should have the same.
> 
> So you can send me two pull requests now, does that make more sense?
> 
I understand and thanks for your comment. I will resend only one pull-request for
extcon to include it for -next branch. I don't send separate pull-request
for bugfixes patch.

Best regards and thanks,
Chanwoo Choi

Re: [GIT PULL] extcon for 3.8-rc4

[Greg KH]

On Wed, Jan 16, 2013 at 12:38:35PM +0900, Chanwoo Choi wrote:
> >>  OK, I will resend pull-request to include only bugfixes patch in 3.8.
> >> After released v3.8-rc7 or 3.8-rc8 kernel, I will send pull-request of extcon
> >> to include new feature patches of extcon driver in 3.9.
> > 
> > No, you can send me that pull request now as well, I have two different
> > branches, one to go to Linus for this release, and one for the next one.
> > Both of them show up in linux-next.  You should have the same.
> > 
> > So you can send me two pull requests now, does that make more sense?
> > 
> I understand and thanks for your comment. I will resend only one pull-request for
> extcon to include it for -next branch. I don't send separate pull-request
> for bugfixes patch.

Why not send a bugfix pull request?  Are none of these for 3.8?  If so,
fine, but be sure to go through them to determine this.

thanks,

greg k-h

Re: [GIT PULL] extcon for 3.8-rc4

[Chanwoo Choi]

On 01/16/2013 03:46 PM, Greg KH wrote:
> On Wed, Jan 16, 2013 at 12:38:35PM +0900, Chanwoo Choi wrote:
>>>>  OK, I will resend pull-request to include only bugfixes patch in 3.8.
>>>> After released v3.8-rc7 or 3.8-rc8 kernel, I will send pull-request of extcon
>>>> to include new feature patches of extcon driver in 3.9.
>>>
>>> No, you can send me that pull request now as well, I have two different
>>> branches, one to go to Linus for this release, and one for the next one.
>>> Both of them show up in linux-next.  You should have the same.
>>>
>>> So you can send me two pull requests now, does that make more sense?
>>>
>> I understand and thanks for your comment. I will resend only one pull-request for
>> extcon to include it for -next branch. I don't send separate pull-request
>> for bugfixes patch.
> 
> Why not send a bugfix pull request?  Are none of these for 3.8?  If so,
> fine, but be sure to go through them to determine this.

I think that it isn't critical bug and relevant to extcon core driver.
And The issue is trivial and depend on new feature of max77693 extcon driver.

Thank you,
Chanwoo Choi