public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Terje Bergström" <tbergstrom@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Arto Merilainen <amerilainen@nvidia.com>,
	"airlied@linux.ie" <airlied@linux.ie>,
	"thierry.reding@avionic-design.de"
	<thierry.reding@avionic-design.de>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv5 7/8] ARM: tegra: Add board data and 2D clocks
Date: Wed, 16 Jan 2013 10:10:09 +0200	[thread overview]
Message-ID: <50F66061.20509@nvidia.com> (raw)
In-Reply-To: <50F5A3A6.7000801@wwwdotorg.org>

On 15.01.2013 20:44, Stephen Warren wrote:
> On 01/15/2013 04:26 AM, Terje Bergstrom wrote:
>> Add a driver alias gr2d for Tegra 2D device, and assign a duplicate
>> of 2D clock to that driver alias.
> 
> FYI on this one patch - it won't be applied to the Tegra tree until
> after Prashant's common clock framework changes are applied. As such, it
> will need some rework once those patches are applied, or perhaps won't
> even be relevant any more; see below.

It looks like I need to just drop the patch 7(8 "ARM: tegra: Add board
data and 2D clocks" and change the 2D code to access the clock without a
name. Do you agree?

I'll roll this into the next patch version once I've gathered more comments.

diff --git a/drivers/gpu/host1x/drm/gr2d.c b/drivers/gpu/host1x/drm/gr2d.c
index dc7d6c6..a1c5f5c 100644
--- a/drivers/gpu/host1x/drm/gr2d.c
+++ b/drivers/gpu/host1x/drm/gr2d.c
@@ -259,7 +259,7 @@ static int gr2d_probe(struct platform_device *dev)
        if (!gr2d)
                return -ENOMEM;

-       gr2d->clk = devm_clk_get(&dev->dev, "gr2d");
+       gr2d->clk = devm_clk_get(&dev->dev, NULL);
        if (IS_ERR(gr2d->clk)) {
                dev_err(&dev->dev, "cannot get clock\n");
                return PTR_ERR(gr2d->clk);

Terje

  parent reply	other threads:[~2013-01-16  8:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-15 11:26 [PATCHv5 0/8] Support for Tegra 2D hardware Terje Bergstrom
2013-01-15 11:26 ` [PATCHv5 1/8] gpu: host1x: Add host1x driver Terje Bergstrom
2013-01-15 11:26 ` [PATCHv5 2/8] gpu: host1x: Add syncpoint wait and interrupts Terje Bergstrom
2013-01-15 11:26 ` [PATCHv5 3/8] gpu: host1x: Add channel support Terje Bergstrom
2013-01-15 11:26 ` [PATCHv5 4/8] gpu: host1x: Add debug support Terje Bergstrom
2013-01-15 11:26 ` [PATCHv5 5/8] drm: tegra: Move drm to live under host1x Terje Bergstrom
2013-01-15 11:26 ` [PATCHv5 6/8] gpu: host1x: Remove second host1x driver Terje Bergstrom
2013-01-15 11:26 ` [PATCHv5 7/8] ARM: tegra: Add board data and 2D clocks Terje Bergstrom
2013-01-15 18:44   ` Stephen Warren
2013-01-16  6:09     ` Terje Bergström
2013-01-16  8:10     ` Terje Bergström [this message]
2013-01-16 17:25       ` Stephen Warren
2013-01-15 11:26 ` [PATCHv5 8/8] drm: tegra: Add gr2d device Terje Bergstrom
2013-01-15 11:33 ` [PATCHv5 0/8] Support for Tegra 2D hardware Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F66061.20509@nvidia.com \
    --to=tbergstrom@nvidia.com \
    --cc=airlied@linux.ie \
    --cc=amerilainen@nvidia.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox